Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC Fix sphinx warnings related to example reformatting. #22147

Merged
merged 2 commits into from Jan 8, 2022
Merged

DOC Fix sphinx warnings related to example reformatting. #22147

merged 2 commits into from Jan 8, 2022

Conversation

@cmarmo
Copy link
Member

@cmarmo cmarmo commented Jan 7, 2022

What does this implement/fix? Explain your changes.

This pull request fix some sphinx warnings arisen in example reformatting

  • target not found
  • unexpected unindent
  • images not found
thomasjpfan
thomasjpfan reviewed Jan 8, 2022
View changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Thank you for the fixes @cmarmo! Can we reduce this PR to only update plot_calibration_curve.py and plot_kernel_pca.py for now? They look good to me.

I think the fix to doc/modules/manifold.rst requires its own PR where we update plot_lle_digits to generate the images again.

doc/modules/manifold.rst Outdated
@@ -106,11 +98,6 @@ Isomap seeks a lower-dimensional embedding which maintains geodesic
distances between all points. Isomap can be performed with the object
:class:`Isomap`.

.. figure:: ../auto_examples/manifold/images/sphx_glr_plot_lle_digits_005.png
Copy link
Member

@thomasjpfan thomasjpfan Jan 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of the images from this file has been removed because of #20543

The site in 0.24 has images for each context: https://scikit-learn.org/0.24/modules/manifold.html

I think we need to rework plot_lle_digits again so the user guide actually displays the images like it did before. WDYT @glemaitre ?

@cmarmo
Copy link
Member Author

@cmarmo cmarmo commented Jan 8, 2022

@thomasjpfan , done. Perhaps this is mergeable and we can open a dedicated issue for manifold.rst? Thanks.

thomasjpfan
thomasjpfan approved these changes Jan 8, 2022
View changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

LGTM

@thomasjpfan thomasjpfan merged commit 49588ff into scikit-learn:main Jan 8, 2022
31 checks passed
@cmarmo cmarmo deleted the fix-warnings-doc branch Jan 8, 2022
@cmarmo cmarmo mentioned this pull request Jan 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet
2 participants
@cmarmo @thomasjpfan