Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RateLimiter] Make RateLimiter resilient to timeShifting #44354

Merged
merged 1 commit into from Dec 15, 2021
Merged

[RateLimiter] Make RateLimiter resilient to timeShifting #44354

merged 1 commit into from Dec 15, 2021

Conversation

jderusse
Copy link
Member

@jderusse jderusse commented Nov 30, 2021

Q A
Branch? 5.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

When 2 servers use the FixedWindowLimiter and do not have the exact same clock (with microsecond precision) the Window might return 0 available tokens.

@carsonbot carsonbot added this to the 5.3 milestone Nov 30, 2021
@nicolas-grekas nicolas-grekas requested a review from wouterj Dec 1, 2021
@carsonbot carsonbot changed the title Make RateLimiter resilient to timeShifting [RateLimiter] Make RateLimiter resilient to timeShifting Dec 2, 2021
@nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Dec 15, 2021

Thank you @jderusse.

@nicolas-grekas nicolas-grekas merged commit 9b1dcc5 into symfony:5.3 Dec 15, 2021
10 of 11 checks passed
@fabpot fabpot mentioned this pull request Dec 29, 2021
Merged
@fabpot fabpot mentioned this pull request Dec 29, 2021
Merged
@fabpot fabpot mentioned this pull request Dec 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj

Assignees
No one assigned
Labels
Bug RateLimiter Status: Needs Review
Projects
None yet
Milestone
5.3
Linked issues

Successfully merging this pull request may close these issues.

None yet
3 participants
@jderusse @nicolas-grekas @carsonbot