Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PropertyAccess] Fix accessing public property on Object #44419

Merged
merged 1 commit into from Dec 11, 2021
Merged

[PropertyAccess] Fix accessing public property on Object #44419

merged 1 commit into from Dec 11, 2021

Conversation

kevcomparadise
Copy link
Contributor

@kevcomparadise kevcomparadise commented Dec 2, 2021 •
edited by nicolas-grekas

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #37026, fix #37615
License MIT
Doc PR no

@carsonbot carsonbot added this to the 5.4 milestone Dec 2, 2021
@carsonbot
Copy link

@carsonbot carsonbot commented Dec 2, 2021

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@kevcomparadise kevcomparadise mentioned this pull request Dec 2, 2021
Closed
@kevcomparadise kevcomparadise changed the title [PropertyAccess] Fix accessing public property in Object [PropertyAccess] Fix accessing public property on Object Dec 2, 2021
@carsonbot
Copy link

@carsonbot carsonbot commented Dec 3, 2021

Hey!

I think @HeahDude has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@xabbuh
Copy link
Member

@xabbuh xabbuh commented Dec 3, 2021

Can you please add a test case for what Fabien described in #37622 (comment) to make sure that we do not break those use cases?

@xabbuh xabbuh removed this from the 5.4 milestone Dec 3, 2021
@xabbuh xabbuh added this to the 5.3 milestone Dec 3, 2021
@xabbuh
Copy link
Member

@xabbuh xabbuh commented Dec 3, 2021

Will this also fix #37615?

@kevcomparadise
Copy link
Contributor Author

@kevcomparadise kevcomparadise commented Dec 3, 2021 •
edited

Will this also fix #37615?

@xabbuh Yes it will also fix, i wrote test for that

@kevcomparadise
Copy link
Contributor Author

@kevcomparadise kevcomparadise commented Dec 3, 2021 •
edited

Can you please add a test case for what Fabien described in #37622 (comment) to make sure that we do not break those use cases?

@xabbuh For that maybe I'm wrong but testGetValueIgnoresMagicGet covers this case no ?

@xabbuh
Copy link
Member

@xabbuh xabbuh commented Dec 3, 2021

Not sure, if I don't miss anything, that test was already present at the time #37622 was merged.

@kevcomparadise
Copy link
Contributor Author

@kevcomparadise kevcomparadise commented Dec 3, 2021

Not sure, if I don't miss anything, that test was already present at the time #37622 was merged.

@xabbuh Ok, i also wrote test for that

@kevcomparadise
Copy link
Contributor Author

@kevcomparadise kevcomparadise commented Dec 8, 2021

Hi, Did you have time to watch ? @xabbuh thx :)

@nicolas-grekas nicolas-grekas mentioned this pull request Dec 11, 2021
Merged
nicolas-grekas added a commit that referenced this issue Dec 11, 2021
@nicolas-grekas
minor #44566 [PropertyAccess] Add tests accessing public (dynamic) pr…
2381e0d 
…operties (kevcomparadise)

This PR was merged into the 4.4 branch.

Discussion
----------

[PropertyAccess] Add tests accessing public (dynamic) properties

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Backporting tests from #44419

Commits
-------

29eec31 [PropertyAccess] Add tests accessing public (dynamic) properties
@nicolas-grekas nicolas-grekas changed the base branch from 5.4 to 5.3 Dec 11, 2021
@nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Dec 11, 2021

Thank you @kevcomparadise.

@nicolas-grekas nicolas-grekas merged commit 1e50d49 into symfony:5.3 Dec 11, 2021
8 of 11 checks passed
@kevcomparadise kevcomparadise deleted the bug/dynamic-property branch Dec 13, 2021
@fabpot fabpot mentioned this pull request Dec 29, 2021
Merged
@fabpot fabpot mentioned this pull request Dec 29, 2021
Merged
@fabpot fabpot mentioned this pull request Dec 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalasr chalasr

@dunglas dunglas

@jderusse jderusse

@lyrixx lyrixx

@OskarStark OskarStark

@wouterj wouterj

@xabbuh xabbuh

@yceruto yceruto

Assignees
No one assigned
Labels
Bug PropertyAccess Status: Needs Review
Projects
None yet
Milestone
5.3
Linked issues

Successfully merging this pull request may close these issues.

None yet
4 participants
@kevcomparadise @carsonbot @xabbuh @nicolas-grekas