Make enable_authenticator_manager true as there is no other way in Symfony 6 #44554
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
reviewed
Dec 10, 2021
| @@ -65,7 +65,7 @@ public function getConfigTreeBuilder(): TreeBuilder | |||
| ->end() | |||
| ->booleanNode('hide_user_not_found')->defaultTrue()->end() | |||
| ->booleanNode('erase_credentials')->defaultTrue()->end() | |||
| ->booleanNode('enable_authenticator_manager')->defaultFalse()->info('Enables the new Symfony Security system based on Authenticators, all used authenticators must support this before enabling this.')->end() | |||
| ->booleanNode('enable_authenticator_manager')->defaultTrue()->info('Enables the new Symfony Security system based on Authenticators, all used authenticators must support this before enabling this.')->end() | |||
There was a problem hiding this comment.
to what should we change the text as this is not longer true in symfony 6 as no other authenticators and authenticator systems exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Did read the new docs and I was confused about:
as I thought thats the default now and there is no other way. And that seems to case as if you set it to false it will error in:
symfony/src/Symfony/Bundle/SecurityBundle/DependencyInjection/SecurityExtension.php
Lines 93 to 95 in 6ab662b
So I would remove the
enable_authenticator_manageralso from the 6.0 docs and make this just the default to avod confusion here.The text was updated successfully, but these errors were encountered: