Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form] Expand FormView key to include int #44764

Merged
merged 1 commit into from Dec 26, 2021
Merged

[Form] Expand FormView key to include int #44764

merged 1 commit into from Dec 26, 2021

Conversation

@biozshock
Copy link
Contributor

@biozshock biozshock commented Dec 22, 2021

Q A
Branch? 5.4
Bug fix? yes
New feature? yes
Deprecations? no
License MIT

Annotate FormView to also have integer keys. For example collection of forms has integers as keys.

@carsonbot
Copy link

@carsonbot carsonbot commented Dec 23, 2021

Hey!

I think @VincentLanglet has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

fabpot
fabpot approved these changes Dec 26, 2021
@fabpot
Copy link
Member

@fabpot fabpot commented Dec 26, 2021

Thank you @biozshock.

@fabpot fabpot merged commit fe76728 into symfony:5.4 Dec 26, 2021
11 of 12 checks passed
@biozshock biozshock deleted the patch-2 branch Dec 27, 2021
@fabpot fabpot mentioned this pull request Dec 29, 2021
@fabpot fabpot mentioned this pull request Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants