Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Typos found by codespell #21069

Merged
merged 5 commits into from Sep 17, 2021

Conversation

@DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Sep 16, 2021

Reference Issues/PRs

#21051

What does this implement/fix? Explain your changes.

A one-shot fix of typos currently found by codespell.

Copy link
Member

@ogrisel ogrisel left a comment

The following typos should not be fixed as they are present in the original openml dataset columns spec.

Other than that, and assuming it fixes the problem. LGTM.

sklearn/datasets/tests/test_openml.py Outdated Show resolved Hide resolved
sklearn/datasets/tests/test_openml.py Outdated Show resolved Hide resolved
@DimitriPapadopoulos DimitriPapadopoulos force-pushed the codespell_typos branch 3 times, most recently from 3e8f355 to 9777166 Sep 16, 2021
Copy link
Member

@lorentzenchr lorentzenchr left a comment

A few of those are from me 😊

doc/modules/outlier_detection.rst Outdated Show resolved Hide resolved
sklearn/cluster/_k_means_elkan.pyx Outdated Show resolved Hide resolved
sklearn/cluster/_k_means_elkan.pyx Outdated Show resolved Hide resolved
sklearn/cluster/_k_means_lloyd.pyx Outdated Show resolved Hide resolved
DimitriPapadopoulos and others added 4 commits Sep 17, 2021
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
@lorentzenchr lorentzenchr merged commit f71c031 into scikit-learn:main Sep 17, 2021
32 of 33 checks passed
@lorentzenchr
Copy link
Member

@lorentzenchr lorentzenchr commented Sep 17, 2021

@DimitriPapadopoulos Thank you for correcting those typos.

@DimitriPapadopoulos DimitriPapadopoulos deleted the codespell_typos branch Sep 17, 2021
adrinjalali added a commit to adrinjalali/scikit-learn that referenced this issue Sep 20, 2021
Copy link
Member

@adrinjalali adrinjalali left a comment

LGTM

samronsin added a commit to samronsin/scikit-learn that referenced this issue Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants