[DependencyInjection] copy synthetic status when resolving child definitions #44986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd prefer doing that in ResolveInstanceofConditionalsPass. Doable? |
|
I'll need some direction for where to do this in |
|
just after |
|
The definition is still synthetic at this point - this is being copied when converting to |
nicolas-grekas
reviewed
Jan 14, 2022
src/Symfony/Component/DependencyInjection/Compiler/ResolveChildDefinitionsPass.php
Outdated
Show resolved
Hide resolved
|
Thank you @kbond. |
nicolas-grekas
force-pushed
the
di-child-synthetic-service
branch
from
9da5da3
to
aad1bf6
Compare
This was referenced Jan 28, 2022
Merged
Merged
Merged
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Appears to be the simplest fix for #44972. The only place this appears to be a problem is when using the
lint:containercommand with an auto-configured kernel in 5.3+.