Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45925: Update macOS installer to SQLite 3.37.2 #30921

Merged
merged 4 commits into from Feb 1, 2022
Merged

bpo-45925: Update macOS installer to SQLite 3.37.2 #30921

merged 4 commits into from Feb 1, 2022

Conversation

@kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Jan 26, 2022 •
edited by bedevere-bot

https://bugs.python.org/issue45925
@kumaraditya303 kumaraditya303 requested a review from as a code owner Jan 26, 2022
@kumaraditya303 kumaraditya303 mentioned this pull request Jan 26, 2022
Merged
erlend-aasland
erlend-aasland approved these changes Jan 26, 2022
View changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

LGTM. Please fix PR title: SQlite => SQLite ;)

@erlend-aasland erlend-aasland requested a review from ned-deily Jan 26, 2022
@kumaraditya303 @erlend-aasland
Update Misc/NEWS.d/next/Build/2022-01-26-12-04-09.bpo-45925.yBSiYO.rst
91f6a9a 
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@kumaraditya303 kumaraditya303 changed the title bpo-45925: Update macOS installer to SQlite 3.37.2 bpo-45925: Update macOS installer to SQLite 3.37.2 Jan 27, 2022
@ned-deily ned-deily merged commit 0e4bef7 into python:main Feb 1, 2022
11 of 12 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Feb 1, 2022

Thanks @kumaraditya303 for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Feb 1, 2022

Sorry, @kumaraditya303 and @ned-deily, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 0e4bef7a7f6f25a6f39755778c73e7026901611f 3.10

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Feb 1, 2022

Sorry @kumaraditya303 and @ned-deily, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 0e4bef7a7f6f25a6f39755778c73e7026901611f 3.9

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Feb 1, 2022

Thanks @kumaraditya303 for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Feb 1, 2022

Thanks @kumaraditya303 for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Feb 1, 2022

Sorry, @kumaraditya303 and @ned-deily, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 0e4bef7a7f6f25a6f39755778c73e7026901611f 3.9

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Feb 1, 2022

Sorry @kumaraditya303 and @ned-deily, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 0e4bef7a7f6f25a6f39755778c73e7026901611f 3.10

@ned-deily
Copy link
Member

@ned-deily ned-deily commented Feb 1, 2022

@AlexWaygood I'm working on the backports.

@AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Feb 1, 2022

Yes, sorry, I misread miss-islington's message.

ned-deily added a commit to ned-deily/cpython that referenced this issue Feb 1, 2022
@kumaraditya303 @erlend-aasland @ned-deily
bpo-45925: Update macOS installer to SQLite 3.37.2 (pythonGH-30921)
e5865af 
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Feb 1, 2022

GH-31057 is a backport of this pull request to the 3.10 branch.

ned-deily added a commit that referenced this issue Feb 1, 2022
@kumaraditya303 @erlend-aasland @ned-deily
bpo-45925: Update macOS installer to SQLite 3.37.2 (GH-30921) (GH-31057)
519eb6a 
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
miss-islington added a commit to miss-islington/cpython that referenced this issue Feb 1, 2022
@ned-deily @miss-islington
bpo-45925: Update macOS installer to SQLite 3.37.2 (pythonGH-30921) (p…
9dc3239 
…ythonGH-31057)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
(cherry picked from commit 519eb6a)

Co-authored-by: Ned Deily <nad@python.org>
ned-deily pushed a commit that referenced this issue Feb 1, 2022
@miss-islington
bpo-45925: Update macOS installer to SQLite 3.37.2 (GH-30921) (GH-31057…
a22dd00 
…) (GH-31059)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
(cherry picked from commit 519eb6a)
@kumaraditya303 kumaraditya303 deleted the sqlite branch Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland

@python/macos-team macos-team

@ned-deily ned-deily

Assignees

@ned-deily ned-deily

Labels
CLA signed needs backport to 3.9
Projects
None yet
Milestone
No milestone
7 participants
@kumaraditya303 @miss-islington @ned-deily @AlexWaygood @bedevere-bot @erlend-aasland @the-knights-who-say-ni