Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix documentation typos #30576

Merged
merged 1 commit into from Jan 20, 2022
Merged

Fix documentation typos #30576

merged 1 commit into from Jan 20, 2022

Conversation

pfusik
Copy link
Contributor

@pfusik pfusik commented Jan 13, 2022

No description provided.

@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented Jan 13, 2022

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@pfusik

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jan 13, 2022
kumaraditya303
kumaraditya303 approved these changes Jan 14, 2022
View changes
Copy link
Contributor

@kumaraditya303 kumaraditya303 left a comment

Can you sign the CLA https://www.python.org/psf/contrib/contrib-form/ as it will be required for your future contributions.

@pfusik
Copy link
Contributor Author

pfusik commented Jan 14, 2022

@kumaraditya303 Signed it yesterday.

sobolevn
sobolevn approved these changes Jan 14, 2022
View changes
Copy link
Member

@sobolevn sobolevn left a comment •
edited

Thanks!

  • Typo in Doc/c-api/init_config.rst only exists on 3.10
  • Typon in Doc/howto/descriptor.rst exists on both 3.9 and 3.10

So, I will mark it as "needs backport" to both versions.

@pfusik
Copy link
Contributor Author

pfusik commented Jan 20, 2022

What's the next step with this PR? I see "First-time contributors need a maintainer to approve running workflows."

@sobolevn
Copy link
Member

sobolevn commented Jan 20, 2022

@corona10 can you please help us? 🙂

@corona10 corona10 merged commit d05a663 into python:main Jan 20, 2022
13 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Jan 20, 2022

Thanks @pfusik for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

miss-islington commented Jan 20, 2022

Sorry, @pfusik and @corona10, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker d05a66339b5e07d72d96e4c30a34cc3821bb61a2 3.9

@bedevere-bot
Copy link

bedevere-bot commented Jan 20, 2022

GH-30717 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 20, 2022
@pfusik @miss-islington
no-issue: Fix documentation typos. (pythonGH-30576)
6bb2b85 
(cherry picked from commit d05a663)

Co-authored-by: Piotr Fusik <piotr@fusik.info>
miss-islington added a commit that referenced this pull request Jan 21, 2022
@miss-islington @pfusik
no-issue: Fix documentation typos. (GH-30576)
68a31db 
(cherry picked from commit d05a663)

Co-authored-by: Piotr Fusik <piotr@fusik.info>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn

@corona10 corona10

@kumaraditya303 kumaraditya303

Assignees

@corona10 corona10

Labels
docs Documentation in the Doc dir needs backport to 3.9 skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@pfusik @the-knights-who-say-ni @sobolevn @miss-islington @bedevere-bot @corona10 @kumaraditya303