Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-46442: improve testExceptionCleanupNames #30758

Merged
merged 1 commit into from Jan 22, 2022

Conversation

yellowdusk1590
Copy link
Contributor

@yellowdusk1590 yellowdusk1590 commented Jan 21, 2022

The test tested that explicitly deleting the local variable bound to the exception
did not cause problems, but it did not test what it actually claimed to test, i.e.
that the variable is deleted automatically.

https://bugs.python.org/issue46442

Lib/test/test_exceptions.py Outdated Show resolved Hide resolved
Copy link
Member

@ericvsmith ericvsmith left a comment

With the small noted changes, I think this is ready to commit.

Lib/test/test_exceptions.py Outdated Show resolved Hide resolved
Lib/test/test_exceptions.py Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

bedevere-bot commented Jan 21, 2022

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

The test tested that explicitly deleting the local variable bound to the exception
did not cause problems, but it did not test what it actually claimed to test, i.e.
that the variable is deleted automatically.
@yellowdusk1590
Copy link
Contributor Author

yellowdusk1590 commented Jan 21, 2022

I have made the requested changes; please review again

@bedevere-bot
Copy link

bedevere-bot commented Jan 21, 2022

Thanks for making the requested changes!

@ericvsmith: please review the changes made to this pull request.

@ericvsmith ericvsmith merged commit 82c5322 into python:main Jan 22, 2022
11 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Jan 22, 2022

Thanks @yellowdusk1590 for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 22, 2022
The test tested that explicitly deleting the local variable bound to the exception
did not cause problems, but it did not test what it actually claimed to test, i.e.
that the variable is deleted automatically.
(cherry picked from commit 82c5322)

Co-authored-by: Yellow Dusk <yellow.dusk1590@fastmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Jan 22, 2022

GH-30778 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 22, 2022
The test tested that explicitly deleting the local variable bound to the exception
did not cause problems, but it did not test what it actually claimed to test, i.e.
that the variable is deleted automatically.
(cherry picked from commit 82c5322)

Co-authored-by: Yellow Dusk <yellow.dusk1590@fastmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Jan 22, 2022

GH-30779 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Jan 22, 2022
The test tested that explicitly deleting the local variable bound to the exception
did not cause problems, but it did not test what it actually claimed to test, i.e.
that the variable is deleted automatically.
(cherry picked from commit 82c5322)

Co-authored-by: Yellow Dusk <yellow.dusk1590@fastmail.com>
miss-islington added a commit that referenced this pull request Jan 22, 2022
The test tested that explicitly deleting the local variable bound to the exception
did not cause problems, but it did not test what it actually claimed to test, i.e.
that the variable is deleted automatically.
(cherry picked from commit 82c5322)

Co-authored-by: Yellow Dusk <yellow.dusk1590@fastmail.com>
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
The test tested that explicitly deleting the local variable bound to the exception
did not cause problems, but it did not test what it actually claimed to test, i.e.
that the variable is deleted automatically.
(cherry picked from commit 82c5322)

Co-authored-by: Yellow Dusk <yellow.dusk1590@fastmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants