Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-46468: document that "-m http.server" defaults to port 8000 #30776

Merged
merged 1 commit into from Jan 22, 2022

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented Jan 22, 2022

Code link:

default=8000, type=int,

It's been this way since at least 3.4.

Also improved some wording in the same section.

https://bugs.python.org/issue46468

Automerge-Triggered-By: GH:asvetlov

@asvetlov asvetlov added 🤖 automerge PR will be merged once it's been approved and all CI passed awaiting core review and removed awaiting merge labels Jan 22, 2022
@asvetlov asvetlov merged commit c8a5366 into python:main Jan 22, 2022
12 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Jan 22, 2022

Thanks @JelleZijlstra for the PR, and @asvetlov for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒🤖

@miss-islington
Copy link
Contributor

miss-islington commented Jan 22, 2022

Sorry @JelleZijlstra and @asvetlov, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker c8a536624e8f5d6612e3c275c5b19592583a8cf8 3.10

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 22, 2022
…onGH-30776)

Code link:
https://github.com/python/cpython/blob/70c16468deee9390e34322d32fda57df6e0f46bb/Lib/http/server.pyGH-L1270

It's been this way since at least 3.4.

Also improved some wording in the same section.
(cherry picked from commit c8a5366)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Jan 22, 2022

GH-30786 is a backport of this pull request to the 3.9 branch.

@miss-islington
Copy link
Contributor

miss-islington commented Jan 22, 2022

Thanks @JelleZijlstra for the PR, and @asvetlov for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 22, 2022
…onGH-30776)

Code link:
https://github.com/python/cpython/blob/70c16468deee9390e34322d32fda57df6e0f46bb/Lib/http/server.pyGH-L1270

It's been this way since at least 3.4.

Also improved some wording in the same section.
(cherry picked from commit c8a5366)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Jan 22, 2022

GH-30787 is a backport of this pull request to the 3.10 branch.

@JelleZijlstra JelleZijlstra deleted the issue46468 branch Jan 22, 2022
asvetlov pushed a commit that referenced this pull request Jan 22, 2022
…0776) (#30786)

Code link:
https://github.com/python/cpython/blob/70c16468deee9390e34322d32fda57df6e0f46bb/Lib/http/server.pyGH-L1270

It's been this way since at least 3.4.

Also improved some wording in the same section.
(cherry picked from commit c8a5366)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
asvetlov pushed a commit that referenced this pull request Jan 22, 2022
…0776) (#30787)

Code link:
https://github.com/python/cpython/blob/70c16468deee9390e34322d32fda57df6e0f46bb/Lib/http/server.pyGH-L1270

It's been this way since at least 3.4.

Also improved some wording in the same section.
(cherry picked from commit c8a5366)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@maggyero
Copy link
Contributor

maggyero commented Jan 27, 2022

Thanks! Could you also add the final period here?

.. versionadded:: 3.8
     ``--bind`` argument enhanced to support IPv6

hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
…onGH-30776) (python#30786)

Code link:
https://github.com/python/cpython/blob/70c16468deee9390e34322d32fda57df6e0f46bb/Lib/http/server.pyGH-L1270

It's been this way since at least 3.4.

Also improved some wording in the same section.
(cherry picked from commit c8a5366)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir 🤖 automerge PR will be merged once it's been approved and all CI passed skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants