Skip to content
Permalink
6.1

Commits on Jan 31, 2022

  1. Merge branch '6.0' into 6.1

    * 6.0:
      fix merge
    nicolas-grekas committed Jan 31, 2022
  2. Merge branch '5.4' into 6.0

    * 5.4:
      fix merge
    nicolas-grekas committed Jan 31, 2022
  3. fix merge

    nicolas-grekas committed Jan 31, 2022
  4. Merge branch '6.0' into 6.1

    * 6.0:
      cs fix
    nicolas-grekas committed Jan 31, 2022
  5. Merge branch '5.4' into 6.0

    * 5.4:
      cs fix
    nicolas-grekas committed Jan 31, 2022
  6. cs fix

    nicolas-grekas committed Jan 31, 2022
  7. Merge branch '6.0' into 6.1

    * 6.0:
      fix merge
    nicolas-grekas committed Jan 31, 2022
  8. Merge branch '5.4' into 6.0

    * 5.4:
      fix merge
    nicolas-grekas committed Jan 31, 2022
  9. fix merge

    nicolas-grekas committed Jan 31, 2022
  10. minor #44742 [Validator] check for file existence lazily in loaders (…

    …nicolas-grekas)
    
    This PR was merged into the 6.1 branch.
    
    Discussion
    ----------
    
    [Validator] check for file existence lazily in loaders
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 6.1
    | Bug fix?      | no
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | Fix #39945
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    9135405 [Validator] check for file existence lazily in loaders
    nicolas-grekas committed Jan 31, 2022
  11. Merge branch '6.0' into 6.1

    * 6.0:
      [PropertyAccess] Fix handling of uninitialized property of parent class
      [DomCrawler] ignore bad charsets
      [Validator] Fix minRatio and maxRatio when getting rounded
      [Console] Revert StringInput bc break from #45088
      [Form] Do not fix URL protocol for relative URLs
      [Serializer] make XmlEncoder stateless thus reentrant
    nicolas-grekas committed Jan 31, 2022
  12. Merge branch '5.4' into 6.0

    * 5.4:
      [PropertyAccess] Fix handling of uninitialized property of parent class
      [DomCrawler] ignore bad charsets
      [Validator] Fix minRatio and maxRatio when getting rounded
      [Console] Revert StringInput bc break from #45088
      [Form] Do not fix URL protocol for relative URLs
      [Serializer] make XmlEncoder stateless thus reentrant
    nicolas-grekas committed Jan 31, 2022
  13. Merge branch '4.4' into 5.4

    * 4.4:
      [PropertyAccess] Fix handling of uninitialized property of parent class
      [DomCrawler] ignore bad charsets
      [Validator] Fix minRatio and maxRatio when getting rounded
      [Console] Revert StringInput bc break from #45088
      [Form] Do not fix URL protocol for relative URLs
      [Serializer] make XmlEncoder stateless thus reentrant
    nicolas-grekas committed Jan 31, 2022
  14. bug #38534 [Serializer] make XmlEncoder stateless thus reentrant (con…

    …norhu)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [Serializer] make XmlEncoder stateless thus reentrant
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 5.x
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | Fix #37354
    | License       | MIT
    
    Changing dom property of XmlEncoder to stackable. It fixes a DOMException "Wrong document error". When you calling XmlEncoder->encode() in parallel createDomDocument replaces the DomDocument object.
    Test code:
    https://github.com/connorhu/symfony-serializer/blob/master/test.php
    
    Commits
    -------
    
    693f9ab [Serializer] make XmlEncoder stateless thus reentrant
    nicolas-grekas committed Jan 31, 2022
  15. bug #42253 [Form] Do not fix URL protocol for relative URLs (bogkonst…

    …antin)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [Form] Do not fix URL protocol for relative URLs
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | yes
    | New feature?  | no
    | Tickets | Fix #42329
    | Deprecations? | no
    | License       | MIT
    
    Example when it doesn't work correctly:
    /relative/path
    The data will be changed to "http:///relative/path" (3 slashes)
    
    Commits
    -------
    
    415dc19 [Form] Do not fix URL protocol for relative URLs
    nicolas-grekas committed Jan 31, 2022
  16. bug #45256 [DomCrawler] ignore bad charsets (nicolas-grekas)

    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [DomCrawler] ignore bad charsets
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | Fix #42255
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    7802c1f [DomCrawler] ignore bad charsets
    nicolas-grekas committed Jan 31, 2022
  17. bug #45255 [PropertyAccess] Fix handling of uninitialized property of…

    … parent class (filiplikavcan)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [PropertyAccess] Fix handling of uninitialized property of parent class
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | yes
    | Tickets  | Fix #45233
    | New feature?  | no
    | Deprecations? | no
    | License       | MIT
    
    [This fix](27d5edf#r795578649) introduced a new bug:
    
    ```php
    class X
    {
        public int $a;
    }
    
    class Y extends X
    {
    }
    
    (new Y)->a;
    
    // PropertyAccessor expects: Typed property Y::$a must not be accessed before initialization
    // Actual exception message: Typed property X::$a must not be accessed before initialization
    ```
    
    This prevents from throwing `AccessException` exception and it bubbles up and causes this exception after form submit: "Typed property X::$a must not be accessed before initialization" which would otherwise be handled by PropertyPathAccessor:
    
    ```php
            } catch (PropertyAccessException $e) {
                // ...
    
                return null;
            }
    ```
    
    Commits
    -------
    
    5cd10b0 [PropertyAccess] Fix handling of uninitialized property of parent class
    nicolas-grekas committed Jan 31, 2022
  18. cs fix

    nicolas-grekas committed Jan 31, 2022
  19. feature #44670 [SecurityBundle] Allow to specify a RequestMatcher dir…

    …ectly in an ACL definition (TristanPouliquen)
    
    This PR was squashed before being merged into the 6.1 branch.
    
    Discussion
    ----------
    
    [SecurityBundle] Allow to specify a RequestMatcher directly in an ACL definition
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 6.1
    | Bug fix?      | no
    | New feature?  | yes
    | Deprecations? | no
    | Tickets       | Fix #44103
    | License       | MIT
    | Doc PR        | symfony/symfony-docs#16296
    
    This PR allows users to directly specify a service reference in the definition of an access control rule. The given service MUST implement the `RequestMatcherInterface`.
    
    The goal is to be able to pass custom request matchers, with more complex rules than the standard path, host, ips, ... options to have the same flexibility as the user has in defining his/her firewalls.
    
    Commits
    -------
    
    1b5516e [SecurityBundle] Allow to specify a RequestMatcher directly in an ACL definition
    derrabus committed Jan 31, 2022
  20. bug #45204 [Validator] Fix minRatio and maxRatio when getting rounded…

    … (alexander-schranz)
    
    This PR was squashed before being merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [Validator] Fix minRatio and maxRatio when getting rounded
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | yes
    | New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
    | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tickets       | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
    | License       | MIT
    | Doc PR        | symfony/symfony-docs#... <!-- required for new features -->
    
    Currently the generated ratio get rounded to `1.33` but the inputted ration not. This can end into a strange behaviour when working with example:
    
    ```php
    new Image([
        'maxRatio' => 64 / 48,
        'minRatio' => 64 / 48,
    ]),
    ```
    
    Workaround currently required rounding input value itself:
    
    ```php
    new Image([
        // round ratio the same way as the validator: https://github.com/symfony/symfony/blob/4834d9e224b97f946fe8e13b2ba403bbc212c4ad/src/Symfony/Component/Validator/Constraints/ImageValidator.php#L165
        'maxRatio' => round(64 / 48, 2),
        'minRatio' => round(64 / 48, 2),
    ]),
    ```
    
    Another solution would be removed:
    
    ```diff
    -   $ratio = round($width / $height, 2);
    ```
    
    instead. What do you think?
    
    Commits
    -------
    
    0f85ba0 [Validator] Fix minRatio and maxRatio when getting rounded
    fancyweb committed Jan 31, 2022
  21. bug #45240 [Console] Revert StringInput bc break from #45088 (bobthecow)

    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [Console] Revert StringInput bc break from #45088
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | Fix bobthecow/psysh#703
    | License       | MIT
    | Doc PR        | -
    
    Fix a backwards compatibility break introduced in #45088 and released in v4.4.37, v5.3.14, v5.4.3 and v6.0.3.
    
    I went with `REGEX_UNQUOTED_STRING` by analog to the `REGEX_QUOTED_STRING` constant name, but don't have a strong opinion on what it should be called :)
    
    Commits
    -------
    
    aab2f2a [Console] Revert StringInput bc break from #45088
    fancyweb committed Jan 31, 2022

Commits on Jan 30, 2022

  1. Merge branch '6.0' into 6.1

    * 6.0:
      [DoctrineBridge] Fix compatibility with doctrine/orm 3 in Id generators
      Bump Symfony version to 6.0.5
      Update VERSION for 6.0.4
      Update CHANGELOG for 6.0.4
      Bump Symfony version to 5.4.5
      Update VERSION for 5.4.4
      Update CHANGELOG for 5.4.4
      Update VERSION for 5.3.15
      Update CHANGELOG for 5.3.15
      Remove 5.3 from PR template
      Bump Symfony version to 4.4.38
      Update VERSION for 4.4.37
      Update CONTRIBUTORS for 4.4.37
      Update CHANGELOG for 4.4.37
      [Process] Update PHPDoc to use proper placeholder syntax
      Fixed functional testing description
    derrabus committed Jan 30, 2022
  2. Merge branch '5.4' into 6.0

    * 5.4:
      [DoctrineBridge] Fix compatibility with doctrine/orm 3 in Id generators
      Bump Symfony version to 5.4.5
      Update VERSION for 5.4.4
      Update CHANGELOG for 5.4.4
      Update VERSION for 5.3.15
      Update CHANGELOG for 5.3.15
      Remove 5.3 from PR template
      Bump Symfony version to 4.4.38
      Update VERSION for 4.4.37
      Update CONTRIBUTORS for 4.4.37
      Update CHANGELOG for 4.4.37
      [Process] Update PHPDoc to use proper placeholder syntax
      Fixed functional testing description
    derrabus committed Jan 30, 2022
  3. Merge branch '5.3' into 5.4

    * 5.3:
      Update VERSION for 5.3.15
      Update CHANGELOG for 5.3.15
    derrabus committed Jan 30, 2022
  4. Merge branch '4.4' into 5.4

    * 4.4:
      Remove 5.3 from PR template
      Bump Symfony version to 4.4.38
      Update VERSION for 4.4.37
      Update CONTRIBUTORS for 4.4.37
      Update CHANGELOG for 4.4.37
      [Process] Update PHPDoc to use proper placeholder syntax
      Fixed functional testing description
    derrabus committed Jan 30, 2022
  5. bug #45243 [DoctrineBridge] Fix compatibility with doctrine/orm 3 in …

    …Id generators (ostrolucky)
    
    This PR was merged into the 5.4 branch.
    
    Discussion
    ----------
    
    [DoctrineBridge] Fix compatibility with doctrine/orm 3 in Id generators
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 5.4
    | Bug fix?      | no
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | -
    | License       | MIT
    | Doc PR        |
    
    Method has been renamed, see https://github.com/doctrine/DoctrineBundle/runs/4993900737?check_suite_focus=true
    
    Commits
    -------
    
    c0eede4 [DoctrineBridge] Fix compatibility with doctrine/orm 3 in Id generators
    derrabus committed Jan 30, 2022

Commits on Jan 29, 2022

  1. Bump Symfony version to 6.0.5

    fabpot committed Jan 29, 2022
  2. Merge pull request #45239 from fabpot/release-6.0.4

    released v6.0.4
    fabpot committed Jan 29, 2022
  3. Update VERSION for 6.0.4

    fabpot committed Jan 29, 2022
Older