Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-32598: Use autoconf to detect usable OpenSSL #5242

Merged
merged 1 commit into from Jan 20, 2018
Merged

bpo-32598: Use autoconf to detect usable OpenSSL #5242

merged 1 commit into from Jan 20, 2018

Conversation

@tiran
Copy link
Member

@tiran tiran commented Jan 19, 2018 •
edited by bedevere-bot

Add https://www.gnu.org/software/autoconf-archive/ax_check_openssl.html
to auto-detect compiler flags, linker flags and libraries to compile
OpenSSL extensions. The M4 macro uses pkg-config and falls back to
manual detection.

Add autoconf magic to detect usable X509_VERIFY_PARAM_set1_host()
and related functions.

Refactor setup.py to use new config vars to compile _ssl and _hashlib
modules.

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue32598
@tiran tiran force-pushed the openssl_autoconf branch from 978906b to c4ae7c2 Jan 19, 2018
@tiran tiran changed the title Use autoconf to detect usable OpenSSL bpo-32598: Use autoconf to detect usable OpenSSL Jan 19, 2018
@tiran tiran requested a review from vstinner Jan 19, 2018
@tiran
bpo-32598: Use autoconf to detect usable OpenSSL
e19151e 
Add https://www.gnu.org/software/autoconf-archive/ax_check_openssl.html
to auto-detect compiler flags, linker flags and libraries to compile
OpenSSL extensions. The M4 macro uses pkg-config and falls back to
manual detection.

Add autoconf magic to detect usable X509_VERIFY_PARAM_set1_host()
and related functions.

Refactor setup.py to use new config vars to compile _ssl and _hashlib
modules.

Signed-off-by: Christian Heimes <christian@python.org>
@tiran tiran force-pushed the openssl_autoconf branch from c4ae7c2 to e19151e Jan 19, 2018
@tiran
Copy link
Member Author

@tiran tiran commented Jan 19, 2018

The PR does not use HAVE_X509_VERIFY_PARAM_SET1_HOST. Once this PR has landed, I'll rebase #5128 and use it there.

@ned-deily ned-deily self-assigned this Jan 19, 2018
@tiran tiran mentioned this pull request Jan 20, 2018
Merged
@tiran tiran merged commit ff5be6e into python:master Jan 20, 2018
4 checks passed
@tiran tiran deleted the openssl_autoconf branch Jan 20, 2018
yan12125 added a commit to yan12125/python3-android that referenced this issue Jun 16, 2018
@yan12125
pybuild: unified sysroot
a9a2b64 
And add pkg-config settings to fix the _ssl module on CPython.

As a side note, since python/cpython#5242,
pkg-config should be correctly set up to find non-common OpenSSL paths.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov

@vstinner vstinner

Assignees

@ned-deily ned-deily

Labels
CLA signed
Projects
None yet
Milestone
No milestone
5 participants
@tiran @asvetlov @ned-deily @the-knights-who-say-ni @bedevere-bot