New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-85427: Prevent exits if ArgumentParser.exit_on_error
is False
#30832
base: main
Are you sure you want to change the base?
gh-85427: Prevent exits if ArgumentParser.exit_on_error
is False
#30832
Conversation
Looking inside |
There are other calls to |
I found a duplicate with some more discussion: bpo-41255. From the penultimate comment:
|
ArgumentParser.exit_on_error
is FalseArgumentParser.exit_on_error
is False
ArgumentParser.exit_on_error
is FalseArgumentParser.exit_on_error
is False
Alternative to #27295 |
Backref to #85427 (@jacobtylerwalls please could you update the title to start with gh-85427?). A |
ArgumentParser.exit_on_error
is FalseArgumentParser.exit_on_error
is False
bpo-41255
The
exit_on_error
docs read:From this, I agree with the reporter that all exit paths should raise an exception rather than exit.
https://bugs.python.org/issue46440
Fixes #85427