Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-42982: update pbkdf2 example & add another link #30966

Merged
merged 4 commits into from Jan 27, 2022
Merged

bpo-42982: update pbkdf2 example & add another link #30966

merged 4 commits into from Jan 27, 2022

Conversation

gpshead
Copy link
Member

@gpshead gpshead commented Jan 27, 2022 •
edited by miss-islington

https://bugs.python.org/issue42982

Automerge-Triggered-By: GH:gpshead

gpshead added 2 commits Jan 27, 2022
@gpshead
bpo-42982: update the pbkdf2 example code.
acee472 
along with a comment telling people to read the docs instead of
blindly copy and pasting a value.
@gpshead
Add a link to the stackexchange answer.
55e7145
@gpshead gpshead requested a review from tiran as a code owner Jan 27, 2022
@bedevere-bot bedevere-bot added awaiting core review docs Documentation in the Doc dir labels Jan 27, 2022
@april
Copy link

april commented Jan 27, 2022

Really like these changes, thanks!

@april
Copy link

april commented Jan 27, 2022

Oh, one thing I might recommend would be to link directly to Thomas Pornin's answer directly on that page.

@gpshead
Copy link
Member Author

gpshead commented Jan 27, 2022

Oh, one thing I might recommend would be to link directly to Thomas Pornin's answer directly on that page.

I waffled on whether to do that or not - in the end I think it's best for people to start from the top for more context. that top answer isn't likely to go away without someone somehow writing something even better. mostly i'm just happy for us not to explain this in our own docs. :)

alex
alex approved these changes Jan 27, 2022
View changes
@gpshead gpshead added the 🤖 automerge PR will be merged once it's been approved and all CI passed label Jan 27, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Jan 27, 2022

@gpshead: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor

miss-islington commented Jan 27, 2022

Sorry, I can't merge this PR. Reason: Head branch was modified. Review and try the merge again..

@miss-islington
Copy link
Contributor

miss-islington commented Jan 27, 2022

@gpshead: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit ace0aa2 into python:main Jan 27, 2022
12 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Jan 27, 2022

Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@gpshead gpshead deleted the docs-example-issue42982 branch Jan 27, 2022
@bedevere-bot
Copy link

bedevere-bot commented Jan 27, 2022

GH-30968 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 27, 2022
@gpshead @miss-islington
bpo-42982: update pbkdf2 example & add another link (pythonGH-30966)
580608a 
Automerge-Triggered-By: GH:gpshead
(cherry picked from commit ace0aa2)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
ned-deily pushed a commit that referenced this pull request Mar 1, 2022
@miss-islington @gpshead
bpo-42982: update pbkdf2 example & add another link (GH-30966) (#30968)
7dbb2f8 
Automerge-Triggered-By: GH:gpshead
(cherry picked from commit ace0aa2)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex alex

@tiran tiran

Assignees
No one assigned
Labels
docs Documentation in the Doc dir 🤖 automerge PR will be merged once it's been approved and all CI passed skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@gpshead @april @miss-islington @bedevere-bot @alex @the-knights-who-say-ni