Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-46563: Add tests for context of exception in finally block #30986

Merged
merged 1 commit into from Jan 28, 2022
Merged

bpo-46563: Add tests for context of exception in finally block #30986

merged 1 commit into from Jan 28, 2022

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Jan 28, 2022 •
edited

@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Jan 28, 2022
@iritkatriel iritkatriel requested a review from brandtbucher Jan 28, 2022
@iritkatriel iritkatriel changed the title bpo-46458: Add tests for context of exception in finally block bpo-46563: Add tests for context of exception in finally block Jan 28, 2022
@iritkatriel iritkatriel marked this pull request as draft Jan 28, 2022
@iritkatriel
Copy link
Member Author

iritkatriel commented Jan 28, 2022

I created a separate bpo for this and converted to draft pending documentation update.

@iritkatriel
Copy link
Member Author

iritkatriel commented Jan 28, 2022

The documentation is fine: https://docs.python.org/3/library/exceptions.html#exception-context

@iritkatriel iritkatriel marked this pull request as ready for review Jan 28, 2022
@iritkatriel iritkatriel merged commit 36f538c into python:main Jan 28, 2022
11 checks passed
@iritkatriel iritkatriel deleted the finally_exception branch Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandtbucher brandtbucher

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@iritkatriel @brandtbucher @the-knights-who-say-ni @bedevere-bot