Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-46604: fix function name in ssl module docstring #31064

Merged
merged 3 commits into from May 3, 2022
Merged

bpo-46604: fix function name in ssl module docstring #31064

merged 3 commits into from May 3, 2022

Conversation

glk0
Copy link
Contributor

@glk0 glk0 commented Feb 1, 2022 •
edited by bedevere-bot

bpo-46604: FIx documentation in ssl module
Replaced function fetch_server_certificate by get_server_certificate in ssl module docstrings

https://bugs.python.org/issue46604

@glk0
Updated module documentation
1c9e057 
The function fetch_server_certificate is replaced by get_server_certificate in the module. I reflected the change in the module docstrings.
@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented Feb 1, 2022

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@glk0

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@merwok merwok changed the title Updated module documentation bpo-46604: fix function name in ssl doc Feb 4, 2022
@merwok merwok changed the title bpo-46604: fix function name in ssl doc bpo-46604: fix function name in ssl module docstring Feb 4, 2022
@iritkatriel iritkatriel requested a review from tiran Mar 29, 2022
JelleZijlstra
JelleZijlstra reviewed May 2, 2022
View changes
Lib/ssl.py Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

bedevere-bot commented May 2, 2022

Every change to Python requires a NEWS entry.

Please, add it using the blurb_it Web app or the blurb command-line tool.

JelleZijlstra
JelleZijlstra approved these changes May 2, 2022
View changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

fetch_server_certificate doesn't exist; get_server_certificate does and fits the description.

The timeout argument didn't exist on 3.9, so we'll have to fix that in the backport.

@JelleZijlstra JelleZijlstra self-assigned this May 2, 2022
@JelleZijlstra JelleZijlstra merged commit feca9bb into python:main May 3, 2022
13 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented May 3, 2022

Thanks @glk0 for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented May 3, 2022

GH-92233 is a backport of this pull request to the 3.10 branch.

@bedevere-bot
Copy link

bedevere-bot commented May 3, 2022

GH-92234 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 3, 2022
@glk0 @miss-islington
bpo-46604: fix function name in ssl module docstring (pythonGH-31064)
1c06518 
The function fetch_server_certificate is replaced by get_server_certificate in the module. I reflected the change in the module docstrings.

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit feca9bb)

Co-authored-by: Kossi GLOKPOR <83467320+glk0@users.noreply.github.com>
miss-islington added a commit that referenced this pull request May 3, 2022
@miss-islington @glk0
bpo-46604: fix function name in ssl module docstring (GH-31064)
58f2d2d 
The function fetch_server_certificate is replaced by get_server_certificate in the module. I reflected the change in the module docstrings.

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit feca9bb)

Co-authored-by: Kossi GLOKPOR <83467320+glk0@users.noreply.github.com>
miss-islington added a commit that referenced this pull request May 3, 2022
@miss-islington @glk0
bpo-46604: fix function name in ssl module docstring (GH-31064)
a23e472 
The function fetch_server_certificate is replaced by get_server_certificate in the module. I reflected the change in the module docstrings.

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit feca9bb)

Co-authored-by: Kossi GLOKPOR <83467320+glk0@users.noreply.github.com>
@glk0 glk0 mannequin mentioned this pull request Apr 10, 2022
Closed
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@miss-islington @glk0 @hello-adam
bpo-46604: fix function name in ssl module docstring (pythonGH-31064)
1d3837a 
The function fetch_server_certificate is replaced by get_server_certificate in the module. I reflected the change in the module docstrings.

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit feca9bb)

Co-authored-by: Kossi GLOKPOR <83467320+glk0@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra

@tiran tiran

Assignees

@JelleZijlstra JelleZijlstra

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@glk0 @the-knights-who-say-ni @bedevere-bot @miss-islington @JelleZijlstra