Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45975: Use walrus operator for while loops in IDLE #31083

Merged
merged 1 commit into from Feb 3, 2022
Merged

bpo-45975: Use walrus operator for while loops in IDLE #31083

merged 1 commit into from Feb 3, 2022

Conversation

nickdrozd
Copy link
Contributor

@nickdrozd nickdrozd commented Feb 2, 2022 •
edited by bedevere-bot

By request of @terryjreedy, these are just the IDLE changes from #29347.

https://bugs.python.org/issue45975

@nickdrozd nickdrozd requested a review from terryjreedy as a code owner Feb 2, 2022
@nickdrozd nickdrozd mentioned this pull request Feb 2, 2022
Merged
@zware zware added the skip news label Feb 2, 2022
@terryjreedy terryjreedy merged commit 51a95be into python:main Feb 3, 2022
11 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Feb 3, 2022

Thanks @nickdrozd for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 3, 2022
@nickdrozd @miss-islington
bpo-45975: Use walrus operator for some idlelib while loops (pythonGH…
f8e1c13 
…-31083)

(cherry picked from commit 51a95be)

Co-authored-by: Nick Drozd <nicholasdrozd@gmail.com>
@miss-islington
Copy link
Contributor

miss-islington commented Feb 3, 2022

Sorry, @nickdrozd and @terryjreedy, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 51a95be1d035a717ab29e98056b8831a98e61125 3.9

@bedevere-bot
Copy link

bedevere-bot commented Feb 3, 2022

GH-31091 is a backport of this pull request to the 3.10 branch.

@miss-islington
Copy link
Contributor

miss-islington commented Feb 3, 2022

Thanks @nickdrozd for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Feb 3, 2022

Sorry @nickdrozd and @terryjreedy, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 51a95be1d035a717ab29e98056b8831a98e61125 3.9

miss-islington added a commit that referenced this pull request Feb 3, 2022
@miss-islington @nickdrozd
bpo-45975: Use walrus operator for some idlelib while loops (GH-31083)
2ddc278 
(cherry picked from commit 51a95be)

Co-authored-by: Nick Drozd <nicholasdrozd@gmail.com>
@terryjreedy
Copy link
Member

terryjreedy commented Feb 3, 2022

I reviewed the changes, ran test_idle, and manually exercised features that should run the affected code.
The merge issue is that the sideport changes are to sections adding in 3.10.

terryjreedy added a commit that referenced this pull request Feb 3, 2022
@terryjreedy
[3.9] bpo-45975: Use walrus operator for some idlelib while loops (GH…
fafd2da 
…-31083)

co-authored by Nick Drozd
cherrypicked from 51a95be
@nickdrozd nickdrozd deleted the idle-walrus branch Feb 3, 2022
@nickdrozd
Copy link
Contributor Author

nickdrozd commented Feb 3, 2022

Thanks for reviewing, @terryjreedy!

hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@terryjreedy @hello-adam
[3.9] bpo-45975: Use walrus operator for some idlelib while loops (py…
ab38b43 
…thonGH-31083)

co-authored by Nick Drozd
cherrypicked from 51a95be
@nickdrozd nickdrozd mannequin mentioned this pull request Dec 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terryjreedy terryjreedy

Assignees

@terryjreedy terryjreedy

Labels
needs backport to 3.9 skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nickdrozd @miss-islington @bedevere-bot @terryjreedy @zware @the-knights-who-say-ni