Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44676: Fix reference leaks in union_reduce #27332

Merged
merged 1 commit into from Jul 24, 2021
Merged

bpo-44676: Fix reference leaks in union_reduce #27332

merged 1 commit into from Jul 24, 2021

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Jul 24, 2021 •
edited by miss-islington

https://bugs.python.org/issue44676

Automerge-Triggered-By: GH:pablogsal

@pablogsal pablogsal mentioned this pull request Jul 24, 2021
Merged
@pablogsal pablogsal requested a review from Fidget-Spinner Jul 24, 2021
Fidget-Spinner
Fidget-Spinner approved these changes Jul 24, 2021
View changes
Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

This is a neat fix :). Didn't know about the N format string.

@Fidget-Spinner
Copy link
Member

Fidget-Spinner commented Jul 24, 2021

Woops I just realized we didn't backport GH-27244. So we don't need to backport this. Thanks the quick fix Pablo!

@pablogsal pablogsal mentioned this pull request Jul 24, 2021
Merged
@pablogsal
Copy link
Member Author

pablogsal commented Jul 24, 2021

I am backporting GH-27244 with this fix in #27333

corona10
corona10 approved these changes Jul 24, 2021
View changes
Copy link
Member

@corona10 corona10 left a comment 


0:00:00 load avg: 3.08 Run tests sequentially
0:00:00 load avg: 3.08 [1/1] test_types
beginning 6 repetitions
123456
......

== Tests result: SUCCESS ==

1 test OK.

Total duration: 1.1 sec
Tests result: SUCCESS

I also checked that this PR fix the leak issue :)

@pablogsal pablogsal added the 🤖 automerge PR will be merged once it's been approved and all CI passed label Jul 24, 2021
@miss-islington
Copy link
Contributor

miss-islington commented Jul 24, 2021

@pablogsal: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 8158e05 into python:main Jul 24, 2021
12 checks passed
@pablogsal pablogsal deleted the bpo-44676 branch Jul 24, 2021
@pablogsal
Copy link
Member Author

pablogsal commented Jul 24, 2021

Thanks for the review @corona10 and @Fidget-Spinner !

sthagen added a commit to sthagen/python-cpython that referenced this pull request Jul 24, 2021
@sthagen
Merge pull request #563 from python/main
53fd5ab 
bpo-44676: Fix reference leaks in union_reduce (pythonGH-27332)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10

@Fidget-Spinner Fidget-Spinner

Assignees
No one assigned
Labels
🤖 automerge PR will be merged once it's been approved and all CI passed skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pablogsal @Fidget-Spinner @miss-islington @corona10 @the-knights-who-say-ni @bedevere-bot