Migrate runtests.py from os.system to subprocess #10121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Alternative PR to #10052. This version uses
subprocess.Also removes code, which was unreachable since mypy requires python 3.5.
Test Plan
The changed have been manually tested on linux and a windows VM with python installed to
C:\Program Files\Python39(So the path contains a space).It was also tested that failure of individual tests still lead to the whole test script failing.
The text was updated successfully, but these errors were encountered: