Remove redundant lookup funcs in fixup.py #11253
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mypy/lookup.py
Outdated
| @@ -10,7 +10,7 @@ | |||
|
|
|||
|
|
|||
| def lookup_fully_qualified(name: str, modules: Dict[str, MypyFile], | |||
| raise_on_missing: bool = False) -> Optional[SymbolTableNode]: | |||
| suppress_errors: bool = False) -> Optional[SymbolTableNode]: | |||
There was a problem hiding this comment.
Negating the meaning of a bool argument can be dangerous, since it will silently change behavior in all call sites that haven't been updated.
I think it's better to leave this unchanged. Instead, you could change mypy/fixup.py to use raise_on_missing instead of suppress_errors for consistency. Changing fixup seems better since it's more of an internal thing.
mypy/fixup.py
Outdated
| @@ -312,8 +298,7 @@ def missing_info(modules: Dict[str, MypyFile]) -> TypeInfo: | |||
| dummy_def.fullname = suggestion | |||
|
|
|||
| info = TypeInfo(SymbolTable(), dummy_def, "<missing>") | |||
| obj_type = lookup_qualified(modules, 'builtins.object', False) | |||
| assert isinstance(obj_type, TypeInfo) | |||
| obj_type = lookup_qualified_typeinfo(modules, 'builtins.object', False) | |||
There was a problem hiding this comment.
For bool arguments it will be clearer to use a keyword argument instead of positional.
mypy/plugins/attrs.py
Outdated
| @@ -87,7 +87,7 @@ def argument(self, ctx: 'mypy.plugin.ClassDefContext') -> Argument: | |||
| if self.converter.name: | |||
| # When a converter is set the init_type is overridden by the first argument | |||
| # of the converter method. | |||
| converter = lookup_qualified_stnode(ctx.api.modules, self.converter.name, True) | |||
| converter = lookup_fully_qualified(self.converter.name, ctx.api.modules, True) | |||
There was a problem hiding this comment.
Nice, it's awkward that this imported a lookup function from mypy.fixup.
|
Thanks for reviewing! Making |
Description
Removes the redundant lookup funcs in fixup.py. Related to #4157.
lookup_qualified_stnode: uncessary nested call tolookup_fully_qualifiedlookup_qualified: inconsistency return types with otherlookup_qualifiedfuncs. Let the callers extract theSymbolNodefrom theSymbolTableNode.