Use unittest for testing instead of pytest #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hauntsaninja
reviewed
Nov 11, 2021
Thanks, can we leave a comment about being careful about doing any pip installs, just in case?
|
Sure, where do you want the comment. In the yaml file? |
hauntsaninja
reviewed
Nov 11, 2021
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
Merged
JelleZijlstra
approved these changes
Nov 11, 2021
Would be good to also have an assertion in the unit test file to make sure we're picking up the right copy of the file (something like assert dirname(typing_extensions.__file__) == dirname(__file__).
It's going to be tricky for people testing the module locally to avoid picking up an installed copy, so it would be useful to provide this check and guidance like using an empty venv.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.
The text was updated successfully, but these errors were encountered: