Skip to content

/ scala-js

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize isInstanceOf on Scala object for interfaces #3815

Open
gzm0 opened this issue Oct 16, 2019 · 0 comments
Open

Optimize isInstanceOf on Scala object for interfaces #3815

gzm0 opened this issue Oct 16, 2019 · 0 comments
Labels
optimization

Comments

@gzm0
Copy link
Contributor

@gzm0 gzm0 commented Oct 16, 2019

This is a follow-up of #2066 that improved instance checking for classes by using JavaScript's instanceof where possible. For interfaces, improvements in the style of master...SebsLittleHelpers:isInstanceOf can still be applied.
@gzm0 gzm0 added the optimization label Oct 16, 2019
@gzm0 gzm0 added this to the Post-v1.0.0 milestone Oct 16, 2019
@gzm0 gzm0 mentioned this issue Oct 16, 2019
Closed
@gzm0 gzm0 removed this from the Post-v1.0.0 milestone Apr 8, 2020
gzm0 added a commit to gzm0/scala-js that referenced this issue Jul 17, 2020
@gzm0
Do not use genMemberNameTree in genJSPropertyES5
3f4e398 
It needlessly wraps a ComputedName around a tree and the type system
fools us into believing we need to handle js.Ident (which we don't).

This leaves one remaining usage of `propertyName` in the ancestors of
the type data. Removing that usage is contingent on scala-js#3815.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
optimization
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@gzm0
You can’t perform that action at this time.