@final: backport bpo-46342 #1026
Conversation
| @@ -2205,6 +2206,81 @@ class Alias: | |||
| def return_tuple(self) -> TupleSelf: | |||
| return (self, self) | |||
|
|
|||
|
|
|||
| class FinalDecoratorTests(BaseTestCase): | |||
There was a problem hiding this comment.
These tests were copied verbatim from CPython
|
Seems like the tests are installing the wrong version of typing-extensions again |
Looks good!
In general, feels safer to always use sys.version_info checks instead of hasattr if we don't always use the typing version of things. E.g., when looking at #1016 I had to lookup when is_typeddict got added to typing (since if it was added in 3.9, we'd do the wrong thing on 3.9.0 and 3.9.1)
|
Now it's just 3.11 that's failing, presumably because the version on GH Actions doesn't have my patch yet. I'll mark 3.11-dev as allowed to fail for now. |
|
OK, CI is green now. @hauntsaninja could you take another look at the changes since your review? |
| @@ -27,12 +27,20 @@ jobs: | |||
| python-version: ${{ matrix.python-version }} | |||
|
|
|||
| - name: Test typing_extensions | |||
| if: matrix.python-version != "3.11-dev" | |||
| run: | | |||
There was a problem hiding this comment.
I think the Github Actions incantation might be something like:
continue-on-error: ${{ matrix.python-version == '3.11-dev' }}
Edit: I thought this would make 3.11 failures more visible, but looks like it doesn't, so feel free to ignore
There was a problem hiding this comment.
Ah you're right, I was reading something that suggested continue-on-error wouldn't work properly
No description provided.
The text was updated successfully, but these errors were encountered: