Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump bazel to 4.2.1 #64455

Closed
wants to merge 1 commit into from
Closed

build: bump bazel to 4.2.1 #64455

wants to merge 1 commit into from

Conversation

@chenrui333
Copy link
Contributor

@chenrui333 chenrui333 commented Sep 2, 2021

No description provided.

@facebook-github-bot
Copy link
Contributor

@facebook-github-bot facebook-github-bot commented Sep 2, 2021

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 1cf2357 (more details on the Dr. CI page):


  • 1/1 failures introduced in this PR

1 failure not recognized by patterns:

Job Step Action
GitHub Actions Lint / mypy Run mypy 🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@codecov
Copy link

@codecov codecov bot commented Sep 3, 2021

Codecov Report

Merging #64455 (1cf2357) into master (7953874) will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #64455      +/-   ##
==========================================
+ Coverage   66.71%   66.79%   +0.07%     
==========================================
  Files         708      708              
  Lines       92330    92330              
==========================================
+ Hits        61596    61668      +72     
+ Misses      30734    30662      -72     

@chenrui333
Copy link
Contributor Author

@chenrui333 chenrui333 commented Sep 3, 2021

Should be good to 🚀 cc @malfet

malfet
malfet approved these changes Sep 3, 2021
Copy link
Contributor

@malfet malfet left a comment

Looks good to mind, but do you mind explaining what's the motivation behind the change?

@facebook-github-bot
Copy link
Contributor

@facebook-github-bot facebook-github-bot commented Sep 3, 2021

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@facebook-github-bot facebook-github-bot commented Sep 10, 2021

@malfet merged this pull request in c12df2d.

@chenrui333
Copy link
Contributor Author

@chenrui333 chenrui333 commented Sep 10, 2021

Looks good to mind, but do you mind explaining what's the motivation behind the change?

TBH, just to keep the build up to date (also trying to find out if bazel has some issue with the latest release or not)

This is just a build config change, it should be technically trivial to update whenever there is a new release.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants