Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-46430: Intern strings in deep-frozen modules #30683

Merged
merged 6 commits into from Feb 9, 2022
Merged

bpo-46430: Intern strings in deep-frozen modules #30683

merged 6 commits into from Feb 9, 2022
+16 −0

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Jan 19, 2022 •
edited by bedevere-bot

gvanrossum
gvanrossum reviewed Jan 19, 2022
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a feeling this isn't going to be enough, alas. :-(

I've tried to drop a few hints in the review. :-)

Tools/scripts/deepfreeze.py Outdated Show resolved Hide resolved
Tools/scripts/deepfreeze.py Outdated Show resolved Hide resolved
Tools/scripts/deepfreeze.py Outdated Show resolved Hide resolved
@kumaraditya303
Copy link
Contributor Author

kumaraditya303 commented Jan 31, 2022 •
edited

I'll revisit this once statically allocated strings land by @ericsnowcurrently See #30928

@kumaraditya303 kumaraditya303 marked this pull request as draft January 31, 2022 07:54
@gvanrossum
Copy link
Member

I'll revisit this once statically allocated strings land by @ericsnowcurrently

To be clear you're referencing faster-cpython/ideas#230 and #30928 here.

gvanrossum
gvanrossum approved these changes Feb 7, 2022
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I just think we shouldn't ignore errors.

Objects/codeobject.c Show resolved Hide resolved
@kumaraditya303 kumaraditya303 marked this pull request as ready for review February 7, 2022 13:22
@kumaraditya303 kumaraditya303 mentioned this pull request Feb 7, 2022
Closed
gvanrossum
gvanrossum approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, fair enough.

@gvanrossum gvanrossum merged commit c0a5ebe into python:main Feb 9, 2022
12 checks passed
@kumaraditya303 kumaraditya303 deleted the intern branch February 9, 2022 19:04
@vstinner
Copy link
Member

The change introduced a regression: https://bugs.python.org/issue46430#msg413822

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methane methane methane approved these changes

@gvanrossum gvanrossum gvanrossum approved these changes

@markshannon markshannon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kumaraditya303 @gvanrossum @vstinner @methane @the-knights-who-say-ni @bedevere-bot