bpo-46750: only import idna when required on several common code paths #31328
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This fixes the linked issue. The reproduction case is:
One caveat is that this changes the exception type for
socket.getaddrinfo
(and probably other socket calls) when the hostname contains a null byte or codepoint: formerly,socket.getaddrinfo("a\u0000b", 443)
orsocket.getaddrinfo(b'a\x00b', 443)
would throwsocket.gaierror: [Errno -2] Name or service not known
, but now they throwTypeError: host name must not contain null character
.I signed the CLA earlier today but it isn't recognized yet, I figured I might as well open the PR now.
Thanks very much for your time.
https://bugs.python.org/issue46750