Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Fixes wheel building #22051

Merged
merged 5 commits into from Dec 24, 2021
Merged

Conversation

@thomasjpfan
Copy link
Member

@thomasjpfan thomasjpfan commented Dec 21, 2021

Fixes wheel building scipy 1.7.3 no longer has manylinux1 wheels on pypi. Either we restrict the scipy version for building or we remove manylinux.

@thomasjpfan thomasjpfan added this to the 1.0.2 milestone Dec 21, 2021
@thomasjpfan thomasjpfan force-pushed the wheel_building_fix branch from 63b6979 to aa8cd96 Dec 21, 2021
@thomasjpfan
Copy link
Member Author

@thomasjpfan thomasjpfan commented Dec 21, 2021

@thomasjpfan thomasjpfan marked this pull request as ready for review Dec 21, 2021
@glemaitre
Copy link
Contributor

@glemaitre glemaitre commented Dec 22, 2021

Would we trigger the following error by not creating the manylinux1: #19233

@glemaitre
Copy link
Contributor

@glemaitre glemaitre commented Dec 22, 2021

The issue with distutils/setuptools/numpy should be solved there: numpy/numpy#20640

@thomasjpfan
Copy link
Member Author

@thomasjpfan thomasjpfan commented Dec 22, 2021

The issue in #19233 came from their configuration was not using pip. manylinux1 is reaching EOL in Jan 2022. The major issue with removing manylinux1 is older systems come default with a pip 9, which can only get manylinux.

The issue with distutils/setuptools/numpy should be solved there: numpy/numpy#20640

This will not fix everything because older version of NumPy will not get the fix.
If the fix is released before we release 1.0.2, then we can revert the setuptools pin.

@thomasjpfan
Copy link
Member Author

@thomasjpfan thomasjpfan commented Dec 22, 2021

I really like how SciPy's pyproject.toml places upper bounds in release branches. Their development branch has no upper bounds.

I think we need to pin setuptools anyways because of pip install scikit-learn will fail for source installs. (which does not have the env set.

@glemaitre
Copy link
Contributor

@glemaitre glemaitre commented Dec 22, 2021

manylinux1 is reaching EOL in Jan 2022

Yep let's drop it then. I think it would be cool to have a note in the release note that something can go sideways with easy_install then.

Copy link
Contributor

@glemaitre glemaitre left a comment

LGTM

@glemaitre glemaitre merged commit 5de723d into scikit-learn:main Dec 24, 2021
58 checks passed
glemaitre added a commit to glemaitre/scikit-learn that referenced this issue Dec 24, 2021
glemaitre added a commit that referenced this issue Dec 25, 2021
venkyyuvy added a commit to venkyyuvy/scikit-learn that referenced this issue Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants