New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-30421: Added fromfile_parent_relative parameter + docs to argparse.ArgumentParser #1698
base: main
Are you sure you want to change the base?
bpo-30421: Added fromfile_parent_relative parameter + docs to argparse.ArgumentParser #1698
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
@efficiosoft, thanks for your PR! By analyzing the history of the files in this pull request, we identified @benjaminp, @birkenfeld and @ezio-melotti to be potential reviewers. |
5cdac77
to
43a13d2
Compare
Ok, CLA is signed now and I'm ready for feedback. Best regards |
I wanted to ask for some progress on this issue. Is there somebody willing to review it? It still merges without conflicts. Best regards |
Ensure compatibility with upstream.
Adding a new parameter is an enhancement that has not been mentioned on the issue, let alone approved. |
Sorry, but what did you mean by "let alone approved"? Just for reference, here is a quote of the docs for the new parameter of
Best regards |
My comment (which constituted my review) was in response to that. You propose to add a new feature with a specific name. AFAIK, neither Bethard nor any other core developer has approved of either the new feature as a concept or the specific name. To seek such approval, you could post to python-ideas list. (I think most proposals other than for tkinter and IDLE should start there.) Briefly describe the idea and rationale and reference the issue and this PR. If you get a positive response, expect discussion of the option (parameter) name. |
Thank you for your explanation. This is my first contribution to cpython, hence thinks went a bit wrong somehow. |
@terryjreedy Ah! I didn't get your response at python-dev. That's why your comment here seemed out-of-context to me. Now I read it and things are clear. Thanks again! |
This PR is stale because it has been open for 30 days with no activity. |
Got issue testing so did a full test then got: 2 tests failed: 9 tests skipped: Total duration: 7 min 26 sec cpython on main [$] via cpython on BPO-30421-argparse_fromfile_parent_relative [$?] via Fatal Python error: init_import_site: Failed to import the site module During handling of the above exception, another exception occurred: Traceback (most recent call last): |
This PR is stale because it has been open for 30 days with no activity. |
Hi
This is a more enhanced version of http://bugs.python.org/issue30421.
It maintains backwards compatibility and docs have been updated as well.
Just for reference, here is the text of my original issue on BPO.
Best regards
Robert
https://bugs.python.org/issue30421