Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update html.parser.rst #30678

Merged
merged 3 commits into from Feb 17, 2022
Merged

Update html.parser.rst #30678

merged 3 commits into from Feb 17, 2022

Conversation

maggyero
Copy link
Contributor

@maggyero maggyero commented Jan 18, 2022 •
edited by miss-islington

This PR for the documentation of the html.parser module will

  • fix a terminology mistake (‘start of a tag’ -> ‘start tag of an element’);
  • mention the parameter names of the HTMLParser.handle_* methods where missing.

Automerge-Triggered-By: GH:merwok

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jan 18, 2022
JelleZijlstra
JelleZijlstra reviewed Jan 19, 2022
View changes
Doc/library/html.parser.rst Outdated Show resolved Hide resolved
merwok
merwok reviewed Jan 31, 2022
View changes
Doc/library/html.parser.rst Outdated Show resolved Hide resolved
@maggyero maggyero requested a review from merwok Feb 11, 2022
@JelleZijlstra JelleZijlstra self-assigned this Feb 17, 2022
@merwok merwok added needs backport to 3.9 needs backport to 3.10 🤖 automerge PR will be merged once it's been approved and all CI passed labels Feb 17, 2022
@miss-islington miss-islington merged commit 2945f5a into python:main Feb 17, 2022
12 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Feb 17, 2022

Thanks @maggyero for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Feb 17, 2022

GH-31385 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 17, 2022
@maggyero @miss-islington
Update html.parser.rst (pythonGH-30678)
1ac4fce 
This PR for the documentation of the [html.parser](https://docs.python.org/3/library/html.parser.html) module will

- fix a terminology mistake (‘start of a tag’ -> ‘start tag of an element’);
- mention the parameter names of the `HTMLParser.handle_*` methods where missing.
(cherry picked from commit 2945f5a)

Co-authored-by: Géry Ogam <gery.ogam@gmail.com>
merwok
merwok approved these changes Feb 17, 2022
View changes
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 17, 2022
@maggyero @miss-islington
Update html.parser.rst (pythonGH-30678)
b7aeab4 
This PR for the documentation of the [html.parser](https://docs.python.org/3/library/html.parser.html) module will

- fix a terminology mistake (‘start of a tag’ -> ‘start tag of an element’);
- mention the parameter names of the `HTMLParser.handle_*` methods where missing.
(cherry picked from commit 2945f5a)

Co-authored-by: Géry Ogam <gery.ogam@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Feb 17, 2022

GH-31386 is a backport of this pull request to the 3.9 branch.

@merwok
Copy link
Member

merwok commented Feb 17, 2022

I should have changed the PR title to get a better commit message, like «Improve wording in html.parser doc»

«update file x» is not very useful, we try to always explain what is done (and often why too).

miss-islington added a commit that referenced this pull request Feb 17, 2022
@miss-islington
[3.10] Update html.parser.rst (GH-30678) (GH-31385)
68e80c4 
This PR for the documentation of the [html.parser](https://docs.python.org/3/library/html.parser.html) module will

- fix a terminology mistake (‘start of a tag’ -> ‘start tag of an element’);
- mention the parameter names of the `HTMLParser.handle_*` methods where missing.
(cherry picked from commit 2945f5a)


Co-authored-by: Géry Ogam <gery.ogam@gmail.com>

Automerge-Triggered-By: GH:merwok
miss-islington added a commit that referenced this pull request Feb 17, 2022
@miss-islington @maggyero
Update html.parser.rst (GH-30678)
0da140d 
This PR for the documentation of the [html.parser](https://docs.python.org/3/library/html.parser.html) module will

- fix a terminology mistake (‘start of a tag’ -> ‘start tag of an element’);
- mention the parameter names of the `HTMLParser.handle_*` methods where missing.
(cherry picked from commit 2945f5a)

Co-authored-by: Géry Ogam <gery.ogam@gmail.com>
@maggyero maggyero deleted the patch-6 branch Feb 17, 2022
@maggyero
Copy link
Contributor Author

maggyero commented Feb 17, 2022 •
edited

Thanks for the review @merwok and @JelleZijlstra. Next time I will choose a better PR title than the default one.

hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@miss-islington @maggyero @hello-adam
Update html.parser.rst (pythonGH-30678)
1724b7e 
This PR for the documentation of the [html.parser](https://docs.python.org/3/library/html.parser.html) module will

- fix a terminology mistake (‘start of a tag’ -> ‘start tag of an element’);
- mention the parameter names of the `HTMLParser.handle_*` methods where missing.
(cherry picked from commit 2945f5a)

Co-authored-by: Géry Ogam <gery.ogam@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merwok merwok

@JelleZijlstra JelleZijlstra

Assignees

@JelleZijlstra JelleZijlstra

Labels
docs Documentation in the Doc dir 🤖 automerge PR will be merged once it's been approved and all CI passed skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@maggyero @miss-islington @bedevere-bot @merwok @JelleZijlstra @the-knights-who-say-ni