Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.8] bpo-44949: Fix test_readline auto history tests (GH-27813) #31118

Merged
merged 1 commit into from Feb 17, 2022
Merged

[3.8] bpo-44949: Fix test_readline auto history tests (GH-27813) #31118

merged 1 commit into from Feb 17, 2022

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Feb 3, 2022 •
edited by bedevere-bot

(cherry picked from commit 6fb62b4)

Co-authored-by: Victor Stinner vstinner@python.org

https://bugs.python.org/issue44949

@vstinner @miss-islington
bpo-44949: Fix test_readline auto history tests (pythonGH-27813)
e8b1805 
(cherry picked from commit 6fb62b4)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-bot bedevere-bot mentioned this pull request Feb 3, 2022
Merged
@vstinner
Copy link
Member

@vstinner vstinner commented Feb 3, 2022

test_readline fails on aarch64 RHEL8 Refleaks 3.8: https://buildbot.python.org/all/#/builders/225/builds/279

FAIL: test_auto_history_disabled (test.test_readline.TestReadline)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.8.cstratak-RHEL8-aarch64.refleak/build/Lib/test/test_readline.py", line 154, in test_auto_history_disabled
    self.assertIn(b"History length: 0\r\n", output)
AssertionError: b'History length: 0\r\n' not found in bytearray(b'dummy input\r\ndummy input\r\nHistory length: 0')

A similar fix was already backported to 3.8 to repair Python 3.8 (RHEL) Refleak buildbots: #28984

@vstinner
Copy link
Member

@vstinner vstinner commented Feb 3, 2022

@ambv: Would you mind to merge this backport? (only tests pass ;-))

@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented Feb 3, 2022

@vstinner and @ambv: Status check is done, and it's a success ✅ .

@ambv ambv merged commit b1bc04d into python:3.8 Feb 17, 2022
12 checks passed
@miss-islington miss-islington deleted the backport-6fb62b4-3.8 branch Feb 17, 2022
@vstinner vstinner mentioned this pull request Feb 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA signed tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@miss-islington @vstinner @ambv @the-knights-who-say-ni @bedevere-bot