[Security] Fix UserNotFoundException is not thrown #45452
Merged
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
damienfa
commented
Feb 17, 2022
•
| Q | A |
|---|---|
| Branch? | 5.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #45070 |
| License | MIT |
| Doc PR | N/A |
carsonbot
changed the title
nicolas-grekas
changed the title
|
Hey! I think @IonBazan has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
nicolas-grekas
reviewed
Feb 18, 2022
| @@ -66,6 +67,13 @@ public function getUser(): UserInterface | |||
| } | |||
|
|
|||
| $user = ($this->userLoader)($this->userIdentifier); | |||
|
|
|||
| // No user has been found via the $this->userLoader callback. | |||
| if (is_null($user)) { | |||
|
Can you please add a test case, and rebase + target 5.4 also? |
|
don't have time to thoroughly check the pr and how does the |
|
@wouterj Can you have a look at this PR? |
wouterj
approved these changes
Mar 26, 2022
With the suggested CS changes, this change looks good to me (for 5.4+).
This code is within the user enumeration control of the authenticator manager - so nothing to worry about concerning that.
| if (is_null($user)) { | ||
| ($exception = new UserNotFoundException())->setUserIdentifier($this->userIdentifier); | ||
| throw $exception; |
There was a problem hiding this comment.
Suggested change
| if (is_null($user)) { | |
| ($exception = new UserNotFoundException())->setUserIdentifier($this->userIdentifier); | |
| throw $exception; | |
| if (null === $user) { | |
| $exception = new UserNotFoundException(); | |
| $exception->setUserIdentifier($this->userIdentifier); | |
| throw $exception; |
fabpot
approved these changes
Mar 27, 2022
|
Thank you @damienfa. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.