Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot read property 'properties' of undefined when adding a lazy loaded module with ng generate #21397

Open
1 of 15 tasks
mjamin opened this issue Jul 22, 2021 · 6 comments
Open
1 of 15 tasks

Comments

@mjamin
Copy link

@mjamin mjamin commented Jul 22, 2021

🐞 Bug report

Command (mark with an x)

  • new
  • build
  • serve
  • test
  • e2e
  • generate
  • add
  • update
  • lint
  • extract-i18n
  • run
  • config
  • help
  • version
  • doc

Description

While attempting to find the module to add a lazy loaded route declaration to while generating a new lazy loaded module with option --module=app, findModuleFromOptions tries file candidates from least to most specific:


[
  '/src/app/areas',
  '/src/app/areas/app.ts',
  '/src/app/areas/app.module.ts'
]

If both app.module.ts and app.ts exist, app.ts is returned. If that file does not include an @angular/core import, this leads to an
Cannot read property 'properties' of undefined error down the line (node is undefined in getMetadataField in ast-utils).

🔬 Minimal Reproduction

  • Create a new angular project using ng new.
  • Create an empty file src/app/app.ts
  • Call ng g m foo --routing --route=foo --module=app

🔥 Exception or Error

Cannot read property 'properties' of undefined

🌍 Your Environment


Angular CLI: 12.1.3
Node: 12.18.3
Package Manager: npm 6.14.6
OS: win32 x64

Angular: 12.1.3
... animations, cli, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1201.3
@angular-devkit/build-angular   12.1.3
@angular-devkit/core            12.1.3
@angular-devkit/schematics      12.1.3
@schematics/angular             12.1.3
rxjs                            6.6.7
typescript                      4.3.5

Workaround

To work around this issue, we can specify the module by file name, not module name:

ng g m foo --routing --route=foo --module=app.module.ts

@iftee-hussain
Copy link
Contributor

@iftee-hussain iftee-hussain commented Jul 31, 2021

If the issue is not taken, I would like to give it a try.

@tejas10191
Copy link

@tejas10191 tejas10191 commented Jul 31, 2021

I'm gonna give it a try too.

@tejas10191
Copy link

@tejas10191 tejas10191 commented Jul 31, 2021

@alan-agius4 Ideally, it should skip the file-path without module.ts extension ?

@iftee-hussain
Copy link
Contributor

@iftee-hussain iftee-hussain commented Jul 31, 2021

IMO it should skip the candidate file path without having moduleExt

@kuldeepvishwakarma05
Copy link

@kuldeepvishwakarma05 kuldeepvishwakarma05 commented Sep 15, 2021

Angular CLI: 12.1.3
Node: 12.18.3
Package Manager: npm 6.14.6
OS: win32 x64

Angular: 12.1.3
... animations, cli, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router

Package Version

@angular-devkit/architect 0.1201.3
@angular-devkit/build-angular 12.1.3
@angular-devkit/core 12.1.3
@angular-devkit/schematics 12.1.3
@schematics/angular 12.1.3
rxjs 6.6.7
typescript 4.3.5

@aakash1003
Copy link

@aakash1003 aakash1003 commented Jan 8, 2022

if this is not resolved yet, then I would like to give it a try

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants