Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace all git.Command.RunInPipeline... with RunWithContext #18553

Open
6543 opened this issue Feb 2, 2022 · 1 comment
Open

replace all git.Command.RunInPipeline... with RunWithContext #18553

6543 opened this issue Feb 2, 2022 · 1 comment

Comments

@6543
Copy link
Member

@6543 6543 commented Feb 2, 2022

cmd.RunInDirTimeoutPipeline,
cmd.RunInDirTimeoutEnvFullPipeline,
cmd.RunInDirFullPipeline,
...

-> cmd.RunWithContext(&git.RunContext{...}

@6543 6543 added this to the 1.17.0 milestone Feb 2, 2022
@lunny
Copy link
Member

@lunny lunny commented Feb 3, 2022

If all has been replaced, then we can rename cmd.RunWithContext to cmd.Run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants