Install types to correct environment #11457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weddige
commented
Nov 4, 2021
|
I am not entirely sure, what the desired behavior for |
Yes, I would agree. Could you have mypy give an error and fail fast in this case please? |
I added a check for that. |
|
Ok, I think this looks good, would you be able to add a few tests please? |
hauntsaninja
approved these changes
Nov 26, 2021
tushar-deepsource
pushed a commit
to deepsourcelabs/mypy
that referenced
this pull request
Jan 20, 2022
Fixes python#11405 by using `options.python_executable` instead of `sys.executable`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Description
Fixes #11405 by using
options.python_executableinstead ofsys.executable.Test Plan
I tested the change manually with an internal project, that was affected by #11405.