Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: remove misleading pytest-xdist comment #22588

Merged
merged 2 commits into from Feb 23, 2022

Conversation

@lesteve
Copy link
Member

@lesteve lesteve commented Feb 23, 2022

Since PYTEST_XDIST_VERSION='latest', pytest-xdist is not disabled contrary to what the comment is saying

Copy link
Member

@jeremiedbb jeremiedbb left a comment

Looks like the person who re-enabled pytest-xdist forgot to remove the comment. Don't want to give names but @glemaitre should agree :D

@jeremiedbb jeremiedbb merged commit a416133 into scikit-learn:main Feb 23, 2022
29 checks passed
@lesteve lesteve deleted the remove-misleading-comment branch Feb 23, 2022
@lesteve
Copy link
Member Author

@lesteve lesteve commented Feb 23, 2022

I think this is the classical "oops I forgot to update the comment after I change the code" thing and you know as long as the CI is green, everything is fine 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants