Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: --env.uglify broken #9165

Merged
merged 4 commits into from Jan 29, 2021
Merged

fix: --env.uglify broken #9165

merged 4 commits into from Jan 29, 2021

Conversation

@NathanaelA
Copy link
Member

@NathanaelA NathanaelA commented Jan 22, 2021

PR Checklist

What is the current behavior?

  • When using --env.uglify the Android build will crash on startup. On both platforms class level CSS will not be applied (and other inconsistencies will occur)
  • Webpack config terserOptions are different per flavor...

What is the new behavior?

  • Fixes it so that the application will behave properly on iOS and Android.
  • Made most the terser options the same between the platforms, and added the --env.ci flag to all the other flavors as it is used to disable terser caching...

Notes

Users will have to either regenerate their webpack.config.js file or manually apply the
keep_classnames:true to the global level terserOptions object as this is a setting that needs to be...

@cla-bot cla-bot bot added the cla: yes label Jan 22, 2021
@NathanWalker NathanWalker merged commit be52cef into master Jan 29, 2021
2 of 4 checks passed
@NathanWalker NathanWalker deleted the fix_webpack_uglify branch Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants