Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update npm in user tests #42841

Merged
merged 6 commits into from Feb 19, 2021
Merged

Update npm in user tests #42841

merged 6 commits into from Feb 19, 2021

Conversation

sandersn
Copy link
Member

@sandersn sandersn commented Feb 17, 2021

I noticed that we were still testing on 5, but that 7 is the current version. So I decided to switch to the repo instead, so that we'll always be up-to-date.

@sandersn
Copy link
Member Author

@sandersn sandersn commented Feb 17, 2021

@typescript-bot user test this

@typescript-bot
Copy link
Collaborator

@typescript-bot typescript-bot commented Feb 17, 2021

Heya @sandersn, I've started to run the parallelized community code test suite on this PR at 104cee2. You can monitor the build here.

@sandersn
Copy link
Member Author

@sandersn sandersn commented Feb 17, 2021

I can get a lot fewer errors (less than a screenful!) with some additions to tsconfig, so I'm going to include that too.

@typescript-bot
Copy link
Collaborator

@typescript-bot typescript-bot commented Feb 17, 2021

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@sandersn
Copy link
Member Author

@sandersn sandersn commented Feb 17, 2021

Found and filed #42843 from looking at the new errors

@sandersn
Copy link
Member Author

@sandersn sandersn commented Feb 19, 2021

No objections in the standup or rest of today, so I'm going to merge this.

@sandersn sandersn merged commit 0eef927 into master Feb 19, 2021
10 checks passed
@sandersn sandersn deleted the update-npm-in-user-tests branch Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants