Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix confusing file name in generated diagnostics file #46821

Merged
merged 2 commits into from Jan 28, 2022
Merged

Fix confusing file name in generated diagnostics file #46821

merged 2 commits into from Jan 28, 2022

Conversation

blaumeise20
Copy link
Contributor

@blaumeise20 blaumeise20 commented Nov 16, 2021

This fixes a confusing generated message.

diagnosticInformationMap.generated.ts line 2:

// generated from './diagnosticInformationMap.generated.ts' by 'src/compiler'
->
// generated from './diagnosticMessages.json' by 'src/compiler'

@typescript-bot
Copy link
Collaborator

@typescript-bot typescript-bot commented Nov 16, 2021

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

@DanielRosenwasser
Copy link
Member

@DanielRosenwasser DanielRosenwasser commented Nov 17, 2021 •
edited

Probably should say "in"

- // generated from './diagnosticMessages.json' by 'src/compiler'
+ // generated from './diagnosticMessages.json' in 'src/compiler'

@sandersn sandersn added this to Not started in PR Backlog Dec 7, 2021
@sandersn sandersn merged commit 0b9f8b4 into microsoft:main Jan 28, 2022
4 checks passed
PR Backlog automation moved this from Not started to Done Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
For Uncommitted Bug Housekeeping
Projects
PR Backlog
  
Done
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet
4 participants
@blaumeise20 @typescript-bot @DanielRosenwasser @sandersn