[HttpKernel] Reset services between requests performed by KernelBrowser #45479
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceruto
approved these changes
Feb 19, 2022
fabpot
approved these changes
Feb 19, 2022
|
Thank you @nicolas-grekas. |
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This fixes memory leaks caused by the container not being reset between requests made via
KernelBrowserwhen not callingKernelBrowser::disableReboot();.There is already a call to
$container->reset()inKernelTestCase::ensureKernelShutdown(), butKernelBrowsercreates new container instances for each requests, and those containers were never reset.