Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebProfilerBundle] add nonces to profiler #44570

Merged
merged 1 commit into from Feb 25, 2022
Merged

Conversation

garak
Copy link
Contributor

@garak garak commented Dec 11, 2021

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #44472
License MIT
Doc PR none

@garak garak force-pushed the profiler-nonce branch from 2c8c394 to cbd670f Dec 11, 2021
@garak
Copy link
Contributor Author

@garak garak commented Dec 11, 2021

Failing test on php 8.0 looks unrelated

@carsonbot carsonbot changed the title add nonces to profiler [WebProfilerBundle] add nonces to profiler Dec 11, 2021
fabpot
fabpot approved these changes Feb 25, 2022
@fabpot
Copy link
Member

@fabpot fabpot commented Feb 25, 2022

Thank you @garak.

@fabpot fabpot merged commit 65e6faa into symfony:4.4 Feb 25, 2022
9 of 11 checks passed
@fabpot fabpot mentioned this pull request Feb 28, 2022
@fabpot fabpot mentioned this pull request Feb 28, 2022
@fabpot fabpot mentioned this pull request Feb 28, 2022
xavismeh added a commit to PandawanTechnology/symfony that referenced this issue Feb 28, 2022
fabpot added a commit that referenced this issue Feb 28, 2022
…d by #44570 (xavismeh)

This PR was merged into the 4.4 branch.

Discussion
----------

[WebProfilerBundle] Fixes HTML syntax regression introduced by #44570

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | N/A
| License       | MIT
| Doc PR        | N/A

The PR #44570 introduced an invalid HTML syntax and this PR fixes this regression

Commits
-------

c555813 [WebProfilerBundle] Fixes HTML syntax regression introduced by #44570
derrabus added a commit that referenced this issue Feb 28, 2022
* 4.4:
  [WebProfilerBundle] Fixes HTML syntax regression introduced by #44570
  Bump Symfony version to 4.4.39
  Update VERSION for 4.4.38
  Update CONTRIBUTORS for 4.4.38
  Update CHANGELOG for 4.4.38
derrabus added a commit that referenced this issue Feb 28, 2022
* 5.4:
  [WebProfilerBundle] Fixes HTML syntax regression introduced by #44570
  Bump Symfony version to 5.4.6
  Update VERSION for 5.4.5
  Update CHANGELOG for 5.4.5
  Bump Symfony version to 4.4.39
  Update VERSION for 4.4.38
  Update CONTRIBUTORS for 4.4.38
  Update CHANGELOG for 4.4.38
derrabus added a commit that referenced this issue Feb 28, 2022
* 6.0:
  [WebProfilerBundle] Fixes HTML syntax regression introduced by #44570
  Bump Symfony version to 6.0.6
  Update VERSION for 6.0.5
  Update CHANGELOG for 6.0.5
  Bump Symfony version to 5.4.6
  Update VERSION for 5.4.5
  Update CHANGELOG for 5.4.5
  Bump Symfony version to 4.4.39
  Update VERSION for 4.4.38
  Update CONTRIBUTORS for 4.4.38
  Update CHANGELOG for 4.4.38
  [Filesystem] Replace occurrences of `operation system` to `operating system`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants