Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Validator] Multi decimal to alpha for CssColor validator #44967

Merged
merged 1 commit into from Feb 25, 2022
Merged

Conversation

tilimac
Copy link
Contributor

@tilimac tilimac commented Jan 10, 2022

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #44966
License MIT
Doc PR symfony/symfony-docs#...

Add multi decimal to alpha value (rgba and hsla) for CssColor validator

@carsonbot
Copy link

@carsonbot carsonbot commented Jan 10, 2022

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@welcoMattic
Copy link
Member

@welcoMattic welcoMattic commented Jan 10, 2022

Hi @tilimac, thank you and congrats for your 1st contribution!
Can you add some tests to cover this modification?

@carsonbot carsonbot changed the title Multi decimal to alpha for CssColor validator [Validator] Multi decimal to alpha for CssColor validator Jan 10, 2022
@tilimac
Copy link
Contributor Author

@tilimac tilimac commented Jan 10, 2022

Thanks you !
I tested my modifications on this site
https://regex101.com/r/5gQ8QQ/1

@stof
Copy link
Member

@stof stof commented Jan 10, 2022

And the CI tells me that your change is wrong, which is also expected when looking at your diff where you add an unescaped / in the middle of a regexp using / delimiters. I guess the regexp you tested is not actually the same than your diff.

Also, you should add test cases covering the cases for which you add support, to prevent regressions.

@tilimac
Copy link
Contributor Author

@tilimac tilimac commented Jan 10, 2022

Mmmh, i don't understand why checks not work with php 8.0

@tilimac
Copy link
Contributor Author

@tilimac tilimac commented Jan 11, 2022

i prepare test cases

fabpot
fabpot approved these changes Feb 25, 2022
@fabpot
Copy link
Member

@fabpot fabpot commented Feb 25, 2022

Thank you @tilimac.

@fabpot fabpot merged commit d2ab9cf into symfony:5.4 Feb 25, 2022
10 of 11 checks passed
@fabpot fabpot mentioned this pull request Feb 28, 2022
@fabpot fabpot mentioned this pull request Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants