Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compatibility for Postponed Evaluation of Annotations (PEP 563) #15739

Open
function2-llx opened this issue Feb 20, 2022 · 1 comment
Open

Add compatibility for Postponed Evaluation of Annotations (PEP 563) #15739

function2-llx opened this issue Feb 20, 2022 · 1 comment
Labels
Good First Issue

Comments

@function2-llx
Copy link

@function2-llx function2-llx commented Feb 20, 2022

Hello,

The code says that it will add compatibility for Postponed Evaluation of Annotations (PEP 563) when Python 3.9 is released (which already happened on 2020.10.5). Is there any plan to complete this?

transformers/src/transformers/hf_argparser.py

Lines 85 to 90 in 2c2a31f

if isinstance(field.type, str):
raise ImportError(
"This implementation is not compatible with Postponed Evaluation of Annotations (PEP 563), "
"which can be opted in from Python 3.7 with `from __future__ import annotations`. "
"We will add compatibility when Python 3.9 is released."
)

@LysandreJik
Copy link
Member

@LysandreJik LysandreJik commented Feb 22, 2022

Hey! We don't have to do the bandwidth to do it right now, but we'd welcome contributions! Let me tag this as a first good issue, and let me know if you're interested in taking a stab at it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@LysandreJik @function2-llx