fix(48053) Description of tsBuildInfoFile is misleading in generated tsconfig.json #48072
Conversation
|
|
|
Note that the handbook also needs to get the new description: https://typescriptlang.org/docs/handbook/compiler-options.html See also #46465, which does the inverse sync. |
|
I've now opened microsoft/TypeScript-Website#2303 to also clarify the handbook. |
There was a problem hiding this comment.
@Blopaa thanks! This looks good to me, but you’ll need to update the baselines so tests pass.
|
tests still fail |
|
It looks like you need to run and update baselines again after merging with main. I’m guessing something else in the last 20 days touched these baselines in a way where the git merge line order was ambiguous. |
| @@ -5,8 +5,8 @@ | |||
| /* Projects */ | |||
| // "incremental": true, /* Save .tsbuildinfo files to allow for incremental compilation of projects. */ | |||
| // "composite": true, /* Enable constraints that allow a TypeScript project to be used with project references. */ | |||
| // "tsBuildInfoFile": "./", /* Specify the folder for .tsbuildinfo incremental compilation files. */ | |||
| // "disableSourceOfProjectReferenceRedirect": true, /* Disable preferring source files instead of declaration files when referencing composite projects. */ | |||
| // "tsBuildInfoFile": "./.tsbuildinfo", /* Specify the path to .tsbuildinfo incremental compilation files. */ | |||
There was a problem hiding this comment.
i think it should be file instead of files
There was a problem hiding this comment.
originally it was files, it must be something else, I did pull to main and ran gulp baseline-accept and it still failed.
There was a problem hiding this comment.
You have to run the tests again before doing gulp baseline-accept
There was a problem hiding this comment.
I agree the message should say file
Blopaa
force-pushed
the
fix#48053
branch
2 times, most recently
from
248c995 to
06bcddf
Compare
|
sorry for the forced pushes, everything is working now, thanks for your patience. |
|
Thanks! |
Fixes #48053