Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Intl.Locale parameter type to toLocale[X]String signatures. #47811

Merged
merged 4 commits into from
Feb 28, 2022
Merged

Add Intl.Locale parameter type to toLocale[X]String signatures. #47811

merged 4 commits into from
Feb 28, 2022

Conversation

jihndai
Copy link
Contributor

@jihndai jihndai commented Feb 9, 2022 •
edited
Loading

Fixes #47802

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Feb 9, 2022
@sandersn sandersn self-assigned this Feb 24, 2022
jakebailey
jakebailey reviewed Feb 28, 2022
View reviewed changes
Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems correct to me, though I think this is the first time the Intl types are being used outside of the intl file itself (besides those defined in es5).

sandersn
sandersn approved these changes Feb 28, 2022
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file structure looks to me like it will work. Let's try it.

@sandersn sandersn merged commit 1abc47b into microsoft:main Feb 28, 2022
@jihndai jihndai deleted the issue/47802 branch February 28, 2022 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakebailey jakebailey jakebailey left review comments

@sandersn sandersn sandersn approved these changes

Assignees

@sandersn sandersn

Labels
For Backlog Bug PRs that fix a backlog bug
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Signature for toLocale[X]String is missing Intl.Locale
4 participants
@jihndai @sandersn @jakebailey @typescript-bot