Skip to content

fix(locale): remove hard coded strings #3193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 4, 2020
Merged

fix(locale): remove hard coded strings #3193

merged 9 commits into from
Feb 4, 2020

Conversation

tiuweehan
Copy link
Contributor

@tiuweehan tiuweehan commented Feb 4, 2020 •
edited
Loading

Related to #2959

Summary

  • Remove hard coded strings and added language translations for the the following components:
Component Language(s)
Markdown widget en, jp
Image widget en, jp
File widget en, jp
Optional en, pl
BitBucket Authentication Page en
GitHub Authentication Page en
GitLab Authentication Page en
Proxy Authentication Page previously added but not updated
Test Authentication Page previously added but not updated

Sample previews

  • Choosing an image
    image
  • Choosing a file
    image
  • Markdown Widget
    image

Took me a while to figure out how netlify-cms-core is connected to the widgets, but now I have a pretty good understanding of how the app works

Credit to @pniedzwiedzinski for removing hard coded string for optional and adding polish translations.

@erezrokah erezrokah self-requested a review February 4, 2020 09:48
@pniedzwiedzinski pniedzwiedzinski mentioned this pull request Feb 4, 2020
Merged
erezrokah
erezrokah approved these changes Feb 4, 2020
View reviewed changes
Copy link
Contributor

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This @tiuweehan and @pniedzwiedzinski! This looks very good. I fixed a small issue that was failing the tests by passing the t function to the raw editor.

@tiuweehan
Copy link
Contributor Author

tiuweehan commented Feb 4, 2020 •
edited
Loading

This @tiuweehan and @pniedzwiedzinski! This looks very good. I fixed a small issue that was failing the tests by passing the t function to the raw editor.

@erezrokah Thanks for helping to review this! I'll try to add more language translations after this.

@pniedzwiedzinski
Copy link
Contributor

This @tiuweehan and @pniedzwiedzinski! This looks very good. I fixed a small issue that was failing the tests by passing the t function to the raw editor.

@erezrokah Thanks for helping to review this! I'll try to add more language translations after this.

I added polish in #3197

@erezrokah erezrokah merged commit fc91bf8 into decaporg:master Feb 4, 2020
@tiuweehan tiuweehan mentioned this pull request Feb 27, 2020
Merged
@vrabe vrabe mentioned this pull request Oct 9, 2020
Merged
vladdu pushed a commit to vladdu/netlify-cms that referenced this pull request Jan 26, 2021
@tiuweehan @vladdu
fix(locale): remove hard coded strings (decaporg#3193)
664abb3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erezrokah erezrokah erezrokah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tiuweehan @pniedzwiedzinski @erezrokah