Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Clippy lints introduced in Rust 1.59 #3562

Merged
merged 5 commits into from Feb 27, 2022

Conversation

fanninpm
Copy link
Contributor

@fanninpm fanninpm commented Feb 25, 2022

@fanninpm
Copy link
Contributor Author

@fanninpm fanninpm commented Feb 25, 2022

@coolreader18 if you could take a look at that Fix needless_late_init Clippy warning commit and see if it's a false positive, that'd be great, thanks!

@fanninpm
Copy link
Contributor Author

@fanninpm fanninpm commented Feb 25, 2022

Also, @qingshi163, you may want to check the Fix let_underscore_lock Clippy error commit just to be safe.

@coolreader18
Copy link
Member

@coolreader18 coolreader18 commented Feb 25, 2022

LGTM, that's the same effect. Only thing I'd say is that drop is in the prelude, so you don't need the std::mem::

@fanninpm fanninpm force-pushed the new-clippy-lints-1.59 branch from d537731 to edbc17f Feb 26, 2022
@fanninpm
Copy link
Contributor Author

@fanninpm fanninpm commented Feb 26, 2022

Re: the Fix let_underscore_lock Clippy error commit, I didn't know if the intention was to drop the lock immediately or to hang onto it until the end of the scope. (c.f. the documentation for that lint)

@coolreader18 coolreader18 merged commit 48fa217 into RustPython:main Feb 27, 2022
10 checks passed
@fanninpm fanninpm deleted the new-clippy-lints-1.59 branch Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants