Skip to content
Permalink
main
Switch branches/tags

Commits on Jul 6, 2022

  1. fix(@schematics/angular): prevent importing RouterModule parallel t…

    …o `RoutingModule`
    
    Prior to this commit, we defined routes in two places example:
    ```ts
    @NgModule({
      declarations: [
        HomeComponent
      ],
      imports: [
        CommonModule,
        RouterModule.forChild(routes),
        HomeRoutingModule
      ]
    })
    export class HomeModule { }
    ```
    
    Closes #17139
    alan-agius4 committed Jul 6, 2022
  2. fix(@angular-devkit/build-angular): improve detection of CommonJS dep…

    …endencies
    
    With this change we include `CommonJsSelfReferenceDependency` and `CommonJsExportsDependency` in the CJS checks.
    
    Closes #23505
    alan-agius4 committed Jul 6, 2022
  3. fix(@angular/cli): during an update only use package manager force op…

    …tion with npm 7+
    
    In some cases previously we passed the `force` option to yarn which which lead to an installation failure.
    
    Closes #23495
    alan-agius4 committed Jul 6, 2022

Commits on Jul 4, 2022

  1. build: lock file maintenance

    angular-robot authored and alan-agius4 committed Jul 4, 2022
  2. build: update angular

    angular-robot authored and alan-agius4 committed Jul 4, 2022
  3. build: enable renovate dependency dashboard

    Enable the Renovate dashboard to see what we are missing/what
    is going on after switching to the self-hosted runner. Renovate
    might avoid some PRs due to previously-closed old PRs with
    the official Mend renovate app operating on upstream branches.
    
    Also provide the Renovate schema.
    devversion authored and alan-agius4 committed Jul 4, 2022
  4. fix(@ngtools/webpack): do not run ngcc when node_modules does not e…

    …xist
    
    Prior to this change the CLI would fail with an error when ngcc could not
    be run due to a missing `node_modules` directory, as is the case with Yarn
    Plug'n'Play for example. The workaround was to create an empty `node_modules`
    directory, but this is inconvenient and shouldn't make any difference.
    
    This commit removes the error and simply skips ngcc processing.
    JoostK authored and alan-agius4 committed Jul 4, 2022

Commits on Jul 1, 2022

  1. fix(@angular/cli): improve error message for project-specific ng comm…

    …ands when run outside of a project
    
    With this change we improve the error message when a project for command cannot be determined
    
    ```
    Error: Cannot determine project for command.
    This is a multi-project workspace and more than one project supports this command. Run "ng build [project]" to execute the command for a specific project or change the current working directory to a project directory.
    
    Available projects are:
    - project-name-0
    - project-name-1
    - project-name-2
    - project-name-3
    - project-name-4
    - project-name-5
    - project-name-6
    - project-name-7
    - project-name-8
    - project-name-9
    ```
    
    Closes #23481
    alan-agius4 authored and clydin committed Jul 1, 2022
  2. fix(@angular-devkit/build-angular): support hidden component styleshe…

    …et sourcemaps with esbuild builder
    
    The hidden stylesheet option was incorrectly being ignored for component
    stylesheets when using the experimental esbuild-based browser application
    builder. The hidden option will now correctly not include the stylesheet
    comment within the stylesheet text for components.
    clydin committed Jul 1, 2022

Commits on Jun 30, 2022

  1. fix(@angular/cli): show deprecated workspace config options in IDE

    With this change deprecated options in angular.json will be visible in the IDE.
    alan-agius4 authored and clydin committed Jun 30, 2022
  2. build: account for rename of angular/code-of-conduct default branch

    We just renamed the Angular code of conduct repository default branch
    to `main`. This repository was not part of the large migration and is
    now handled separately as a little clean-up.
    devversion authored and clydin committed Jun 30, 2022
  3. build: add bazel config that disabled sharding and flaky re-runs

    This is useful when running tests locally as otherwise 50 workers are spawned when running the `//packages/angular_devkit/build_angular:build_angular_browser_test` target even when having an `fit` on a single test. This also disabled re-runs on flaky tests.
    alan-agius4 authored and clydin committed Jun 30, 2022
  4. fix(@angular-devkit/build-angular): don't override base-href in HTML …

    …when it's not set in builder
    
    With this change we fix a regression were we  set the base-href to `/` when the browser builder `baseHref` option is not set.
    
    Closes #23475
    alan-agius4 authored and clydin committed Jun 30, 2022
  5. fix(@angular-devkit/build-angular): disable glob mounting for pattern…

    …s that start with a forward slash
    
    By default, a glob pattern starting with a forward slash will be "mounted" onto the system root. This causes globs to escape the workspace root.
    
    With this change we configure disable glob "mounting" and also change the root to the same setting of the `cwd`.
    
    Closes #23467
    alan-agius4 authored and clydin committed Jun 30, 2022

Commits on Jun 29, 2022

  1. test: remove hardcoded chrome driver version

    The version of the chrome driver is now determined from the webdriver-manager.
    alan-agius4 authored and clydin committed Jun 29, 2022
  2. build: update pull request ng-dev config

    Updated label types to reflect changes in ng-dev
    alan-agius4 authored and clydin committed Jun 29, 2022
  3. build: update angular to d14729d

    renovate[bot] authored and clydin committed Jun 29, 2022
  4. fix(@schematics/angular): use sourceRoot instead of src in univer…

    …sal schematic
    
    With this change we remove the usage of hard coded `src` directory and instead infer this from the `sourceRoot` project option.
    
    We also remove the `angularCompilerOptions.entryModule` property in the server tsconfig as this is no longer needed with Ivy.
    
    Closes #12104
    alan-agius4 authored and clydin committed Jun 29, 2022
  5. fix(@angular-devkit/architect): complete builders on the next event l…

    …oop iteration
    
    Waiting to complete the builder until the next tick allows the logging
    subscription to flush and provide queued logging entries to the builder
    consumer.
    clydin committed Jun 29, 2022

Commits on Jun 28, 2022

  1. fix(@angular-devkit/build-angular): set base-href in service worker m…

    …anifest when using i18n and app-shell
    
    Previously, the base href was not set when using the app-shell builder and i18n.
    
    Closes #22389
    alan-agius4 authored and clydin committed Jun 28, 2022
  2. fix(@ngtools/webpack): restore process title after NGCC is executed

    More context about this can be found in the following comment: #19205 (comment)
    
    Closes #19205
    alan-agius4 authored and clydin committed Jun 28, 2022
  3. fix(@angular-devkit/build-angular): exit localized builds when CTRL+C…

    … is pressed
    
    When using localization we setup `SIGINT` signal to delete the temporary directory. In some cases this resulted in delaying the process from exiting a couple of seconds.
    
    Closes #22216
    alan-agius4 authored and clydin committed Jun 28, 2022
  4. ci: remove flakey test behaviour

    During testing architect isn't spawned as a new process therefore we the global state can be tained from previous runs.
    
    `es5TargetWarningsShown` which was saved in the global state caused flakiness.
    alan-agius4 authored and clydin committed Jun 28, 2022
  5. fix(@ngtools/webpack): show a compilation error on invalid TypeScript…

    … version
    
    A TypeScript version mismatch with the Angular compiler will no longer cause an
    exception to propagate up through the Webpack system. In Node.js v14, this resulted
    in an unhandled promise rejection warning and the build command never completing.
    This can also be reproduced in newer versions of Node.js by using the Node.js
    option `--unhandled-rejections=warn`. To correct this issue, the version mismatch
    is now treated as a compilation error and added to the list of errors that are
    displayed at the end of the build. This also has the benefit of avoiding the stack
    trace of the exception from being shown which previously drew attention away from
    the actual error message.
    clydin committed Jun 28, 2022
  6. refactor: clean up old ansi-colors castings

    This has been fixed in doowb/ansi-colors#44
    alan-agius4 authored and clydin committed Jun 28, 2022
Older