Wildcard for hostname #2721
Closed
Wildcard for hostname #2721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the feature. It would be great if we could encapsulate this logic inside a Utopia validator with proper tests. |
|
Let's add more information in the UI placeholder that allows devs to understand this feature better. |
|
The PR is outdated, I am going to update it 😇 |
|
This PR is a mess, also really old. Closing it, here is a new PR: #3124 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚨 Utopia/framework release required before merge 🚨
What does this PR do?
We currently don't support hostname syntax
*.myweb.comto allow all subdomains. With this PR, you can start using the wildcard symbol*for sections where you want to allow any value.I also added a proper validator, so people are warned when trying to add hostname like
http://myapp.comormyapp:8000.Test Plan
The validator is properly tested at the library level. Current tests should pass.
Before:
After:
(using
https://8080-tringug-authmodal-8l5p3rlrnxe.ws-eu38xl.gitpod.io/examples/appwrite.htmlURL)Related PRs and Issues
#2939
Have you read the Contributing Guidelines on issues?
✄1�7