Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question: Duplicate NaN check ? #3466

Closed
yuxino opened this issue Nov 2, 2017 · 3 comments
Closed

Question: Duplicate NaN check ? #3466

yuxino opened this issue Nov 2, 2017 · 3 comments
Labels
enhancement

Comments

@yuxino
Copy link
Contributor

@yuxino yuxino commented Nov 2, 2017

toFinite method has been checked NaN. Why checked again in toInteger last line ...

lodash/toInteger.js

Line 32 in 102d9e3

return result === result ? (remainder ? result - remainder : result) : 0

lodash/toFinite.js

Line 37 in 102d9e3

return value === value ? value : 0

@jdalton
Copy link
Member

@jdalton jdalton commented Nov 2, 2017

@Nbsaw would you like submit a PR to remove the extra check?

@yuxino
Copy link
Contributor Author

@yuxino yuxino commented Nov 2, 2017

@jdalton of course !

@jaramir jaramir mentioned this issue Apr 19, 2018
Closed
@jaramir jaramir mentioned this issue Apr 19, 2018
Closed
@jaramir jaramir mentioned this issue Apr 19, 2018
Closed
@jaramir jaramir mentioned this issue Apr 20, 2018
Closed
@lock
Copy link

@lock lock bot commented Dec 26, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@jdalton @yuxino